Skip to content

Commit aa8ed06

Browse files
MC-33278: [Magento Cloud] - Magento\Framework\App\DeploymentConfig\Reader::load function is taking too much time
1 parent d4b108a commit aa8ed06

File tree

2 files changed

+16
-9
lines changed

2 files changed

+16
-9
lines changed

lib/internal/Magento/Framework/App/Test/Unit/DeploymentConfigTest.php

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,12 @@
66

77
namespace Magento\Framework\App\Test\Unit;
88

9-
use \Magento\Framework\App\DeploymentConfig;
10-
use \Magento\Framework\Config\ConfigOptionsListConstants;
9+
use Magento\Framework\App\DeploymentConfig;
10+
use Magento\Framework\Config\ConfigOptionsListConstants;
11+
use PHPUnit\Framework\MockObject\MockObject;
12+
use PHPUnit\Framework\TestCase;
1113

12-
class DeploymentConfigTest extends \PHPUnit\Framework\TestCase
14+
class DeploymentConfigTest extends TestCase
1315
{
1416
/**
1517
* @var array
@@ -63,7 +65,7 @@ class DeploymentConfigTest extends \PHPUnit\Framework\TestCase
6365
protected $_deploymentConfigMerged;
6466

6567
/**
66-
* @var \PHPUnit_Framework_MockObject_MockObject
68+
* @var MockObject
6769
*/
6870
private $reader;
6971

@@ -124,7 +126,7 @@ public function testNotAvailable(): void
124126
*/
125127
public function testNotAvailableThenAvailable(): void
126128
{
127-
$this->reader->expects($this->once())->method('load')->willReturn([]);
129+
$this->reader->expects($this->once())->method('load')->willReturn(['Test']);
128130
$object = new DeploymentConfig($this->reader);
129131
$this->assertFalse($object->isAvailable());
130132
$this->assertFalse($object->isAvailable());

lib/internal/Magento/Framework/Module/Test/Unit/ModuleListTest.php

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,14 @@
55
*/
66
namespace Magento\Framework\Module\Test\Unit;
77

8-
use \Magento\Framework\Module\ModuleList;
8+
use Magento\Framework\Module\ModuleList;
9+
use PHPUnit\Framework\MockObject\MockObject;
10+
use PHPUnit\Framework\TestCase;
911

10-
class ModuleListTest extends \PHPUnit\Framework\TestCase
12+
/**
13+
* Test for module list
14+
*/
15+
class ModuleListTest extends TestCase
1116
{
1217
/**
1318
* Fixture for all modules' meta-information
@@ -24,12 +29,12 @@ class ModuleListTest extends \PHPUnit\Framework\TestCase
2429
private static $enabledFixture = ['foo' => 1, 'bar' => 0];
2530

2631
/**
27-
* @var \PHPUnit_Framework_MockObject_MockObject
32+
* @var MockObject
2833
*/
2934
private $config;
3035

3136
/**
32-
* @var \PHPUnit_Framework_MockObject_MockObject
37+
* @var MockObject
3338
*/
3439
private $loader;
3540

0 commit comments

Comments
 (0)