MAGETWO-90940: SEO-friendly URL for category page not working

Author: zakdma

app/code/Magento/Catalog/Controller/Adminhtml/Category.php

@@ -8,11 +8,23 @@
 namespace Magento\Catalog\Controller\Adminhtml;
 
 use Magento\Store\Model\Store;
+use Magento\Backend\App\Action\Context;
+use Magento\Framework\Stdlib\DateTime\Filter\Date;
+use Magento\Catalog\Model\Category as CategoryModel;
+use Magento\Backend\App\Action;
+use Magento\Store\Model\StoreManagerInterface;
+use Magento\Framework\Registry;
+use Magento\Cms\Model\Wysiwyg\Config;
+use Magento\Backend\Model\View\Result\Page;
+use Magento\Framework\Controller\Result\Json;
+use Magento\Backend\Model\Auth\Session;
+use Magento\Framework\DataObject;
+use Zend_Filter_Input;
 
 /**
  * Catalog category controller
  */
-abstract class Category extends \Magento\Backend\App\Action
+abstract class Category extends Action
 {
     /**
      * Authorization level of a basic admin session
@@ -22,17 +34,17 @@ abstract class Category extends \Magento\Backend\App\Action
     const ADMIN_RESOURCE = 'Magento_Catalog::categories';
 
     /**
-     * @var \Magento\Framework\Stdlib\DateTime\Filter\Date
+     * @var Date
      */
     protected $dateFilter;
 
     /**
-     * @param \Magento\Backend\App\Action\Context $context
-     * @param \Magento\Framework\Stdlib\DateTime\Filter\Date|null $dateFilter
+     * @param Context $context
+     * @param Date|null $dateFilter
      */
     public function __construct(
-        \Magento\Backend\App\Action\Context $context,
-        \Magento\Framework\Stdlib\DateTime\Filter\Date $dateFilter = null
+        Context $context,
+        Date $dateFilter = null
     ) {
         $this->dateFilter = $dateFilter;
         parent::__construct($context);
@@ -43,20 +55,20 @@ public function __construct(
      * Root category can be returned, if inappropriate store/category is specified
      *
      * @param bool $getRootInstead
-     * @return \Magento\Catalog\Model\Category|false
+     * @return CategoryModel|false
      */
     protected function _initCategory(bool $getRootInstead = false)
     {
         $categoryId = $this->resolveCategoryId();
         $storeId = $this->resolveStoreId();
-        $category = $this->_objectManager->create(\Magento\Catalog\Model\Category::class);
+        $category = $this->_objectManager->create(CategoryModel::class);
         $category->setStoreId($storeId);
 
         if ($categoryId) {
             $category->load($categoryId);
             if ($storeId) {
                 $rootId = $this->_objectManager->get(
-                    \Magento\Store\Model\StoreManagerInterface::class
+                    StoreManagerInterface::class
                 )->getStore(
                     $storeId
                 )->getRootCategoryId();
@@ -71,9 +83,9 @@ protected function _initCategory(bool $getRootInstead = false)
             }
         }
 
-        $this->_objectManager->get(\Magento\Framework\Registry::class)->register('category', $category);
-        $this->_objectManager->get(\Magento\Framework\Registry::class)->register('current_category', $category);
-        $this->_objectManager->get(\Magento\Cms\Model\Wysiwyg\Config::class)
+        $this->_objectManager->get(Registry::class)->register('category', $category);
+        $this->_objectManager->get(Registry::class)->register('current_category', $category);
+        $this->_objectManager->get(Config::class)
             ->setStoreId($this->getRequest()->getParam('store'));
         return $category;
     }
@@ -105,26 +117,26 @@ private function resolveStoreId(): int
         return $storeId ?: (int)$this->getRequest()->getParam('store_id', Store::DEFAULT_STORE_ID);
     }
 
-    /**
+    /**Zend_Filter_Input
      * Build response for ajax request
      *
-     * @param \Magento\Catalog\Model\Category $category
-     * @param \Magento\Backend\Model\View\Result\Page $resultPage
+     * @param CategoryModel $category
+     * @param Page $resultPage
      *
-     * @return \Magento\Framework\Controller\Result\Json
+     * @return Json
      *
      * @deprecated 101.0.0
      */
     protected function ajaxRequestResponse(
-        \Magento\Catalog\Model\Category $category,
-        \Magento\Backend\Model\View\Result\Page $resultPage
-    ): \Magento\Framework\Controller\Result\Json {
+        CategoryModel $category,
+        Page $resultPage
+    ): Json {
         // prepare breadcrumbs of selected category, if any
         $breadcrumbsPath = $category->getPath();
         if (empty($breadcrumbsPath)) {
             // but if no category, and it is deleted - prepare breadcrumbs from path, saved in session
             $breadcrumbsPath = $this->_objectManager->get(
-                \Magento\Backend\Model\Auth\Session::class
+                Session::class
             )->getDeletedPath(
                 true
             );
@@ -140,7 +152,7 @@ protected function ajaxRequestResponse(
             }
         }
 
-        $eventResponse = new \Magento\Framework\DataObject([
+        $eventResponse = new DataObject([
             'content' => $resultPage->getLayout()->getUiComponent('category_form')->getFormHtml()
                 . $resultPage->getLayout()->getBlock('category.tree')
                     ->getBreadcrumbsJavascript($breadcrumbsPath, 'editingCategoryBreadcrumbs'),
@@ -151,8 +163,8 @@ protected function ajaxRequestResponse(
             'category_prepare_ajax_response',
             ['response' => $eventResponse, 'controller' => $this]
         );
-        /** @var \Magento\Framework\Controller\Result\Json $resultJson */
-        $resultJson = $this->_objectManager->get(\Magento\Framework\Controller\Result\Json::class);
+        /** @var Json $resultJson */
+        $resultJson = $this->_objectManager->get(Json::class);
         $resultJson->setHeader('Content-type', 'application/json', true);
         $resultJson->setData($eventResponse->getData());
         return $resultJson;
@@ -161,12 +173,12 @@ protected function ajaxRequestResponse(
     /**
      * Datetime data preprocessing
      *
-     * @param \Magento\Catalog\Model\Category $category
+     * @param CategoryModel $category
      * @param array $postData
      *
      * @return array
      */
-    protected function dateTimePreprocessing(\Magento\Catalog\Model\Category $category, array $postData): array
+    protected function dateTimePreprocessing(CategoryModel $category, array $postData): array
     {
         $dateFieldFilters = [];
         $attributes = $category->getAttributes();
@@ -177,7 +189,7 @@ protected function dateTimePreprocessing(\Magento\Catalog\Model\Category $catego
                 }
             }
         }
-        $inputFilter = new \Zend_Filter_Input($dateFieldFilters, [], $postData);
+        $inputFilter = new Zend_Filter_Input($dateFieldFilters, [], $postData);
         return $inputFilter->getUnescaped();
     }
 }