Skip to content

Commit a9d6416

Browse files
author
rahul
committed
Fixed Issue #25167:Terms and Conditions css height do nothing on frontend
1 parent abbfa03 commit a9d6416

File tree

3 files changed

+5
-2
lines changed

3 files changed

+5
-2
lines changed

app/code/Magento/CheckoutAgreements/Model/AgreementsConfigProvider.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,8 @@ protected function getAgreementsConfig()
102102
: nl2br($this->escaper->escapeHtml($agreement->getContent())),
103103
'checkboxText' => $this->escaper->escapeHtml($agreement->getCheckboxText()),
104104
'mode' => $agreement->getMode(),
105-
'agreementId' => $agreement->getAgreementId()
105+
'agreementId' => $agreement->getAgreementId(),
106+
'contentHeight' => $agreement->getContentHeight()
106107
];
107108
}
108109

app/code/Magento/CheckoutAgreements/view/frontend/web/js/view/checkout-agreements.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ define([
2323
agreements: agreementsConfig.agreements,
2424
modalTitle: ko.observable(null),
2525
modalContent: ko.observable(null),
26+
contentHeight: ko.observable(null),
2627
modalWindow: null,
2728

2829
/**
@@ -42,6 +43,7 @@ define([
4243
showContent: function (element) {
4344
this.modalTitle(element.checkboxText);
4445
this.modalContent(element.content);
46+
this.contentHeight(element.contentHeight ? element.contentHeight : 'auto');
4547
agreementsModal.showModal();
4648
},
4749

app/code/Magento/CheckoutAgreements/view/frontend/web/template/checkout/checkout-agreements.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535
<!-- /ko -->
3636
<!-- /ko -->
3737
<div id="checkout-agreements-modal" data-bind="afterRender: initModal" style="display: none">
38-
<div class="checkout-agreements-item-content" data-bind="html: modalContent"></div>
38+
<div class="checkout-agreements-item-content" data-bind="html: modalContent, style: {height: contentHeight, overflow:'auto' }"></div>
3939
</div>
4040
</div>
4141
</div>

0 commit comments

Comments
 (0)