magento-engcom/magento2ce#2262: Code style fixes

Author: Stanislav Idolov

app/code/Magento/AdminNotification/Block/Window.php

@@ -8,6 +8,8 @@
 namespace Magento\AdminNotification\Block;
 
 /**
+ * Admin notification window block
+ *
  * @api
  * @since 100.0.2
  */

app/code/Magento/Braintree/Controller/Paypal/Review.php

@@ -12,11 +12,12 @@
 use Magento\Braintree\Gateway\Config\PayPal\Config;
 use Magento\Braintree\Model\Paypal\Helper\QuoteUpdater;
 use Magento\Framework\Exception\LocalizedException;
+use Magento\Framework\App\Action\HttpPostActionInterface;
 
 /**
  * Class Review
  */
-class Review extends AbstractAction
+class Review extends AbstractAction implements HttpPostActionInterface
 {
     /**
      * @var QuoteUpdater
@@ -91,6 +92,8 @@ public function execute()
     }
 
     /**
+     * Validate request data
+     *
      * @param array $requestData
      * @return boolean
      */

lib/internal/Magento/Framework/App/Config/Value.php

@@ -113,9 +113,9 @@ public function getFieldsetDataValue($key)
     }
 
     /**
-     * {@inheritdoc}
+     * @inheritdoc
      *
-     * {@inheritdoc}. In addition, it sets status 'invalidate' for config caches
+     * @inheritdoc. In addition, it sets status 'invalidate' for config caches
      *
      * @return $this
      */
@@ -129,9 +129,9 @@ public function afterSave()
     }
 
     /**
-     * {@inheritdoc}
+     * @inheritdoc
      *
-     * {@inheritdoc}. In addition, it sets status 'invalidate' for config caches
+     * @inheritdoc. In addition, it sets status 'invalidate' for config caches
      *
      * @return $this
      */

lib/internal/Magento/Framework/App/Config/ValueInterface.php

@@ -9,9 +9,9 @@
 
 /**
  * Interface \Magento\Framework\App\Config\ValueInterface
- * 
- * This interface cannot be marked as API since doesn't fit developers' needs of extensibility. In 2.4 we are going 
- * to introduce a new iterface which should cover all needs and deprecate the this one with the model
+ *
+ * This interface cannot be marked as API since doesn't fit developers' needs of extensibility. In 2.4 we are going
+ * to introduce a new interface which should cover all needs and deprecate the this one with the model
  * {@see \Magento\Framework\App\Config\Value}
  */
 interface ValueInterface
@@ -23,6 +23,7 @@ interface ValueInterface
 
     /**
      * Check if config data value was changed
+     *
      * @todo this method should be make as protected
      * @return bool
      */

pub/errors/processor.php

@@ -257,13 +257,7 @@ public function getHostUrl()
         /**
          * Define server http host
          */
-        if (!empty($_SERVER['HTTP_HOST'])) {
-            $host = $_SERVER['HTTP_HOST'];
-        } elseif (!empty($_SERVER['SERVER_NAME'])) {
-            $host = $_SERVER['SERVER_NAME'];
-        } else {
-            $host = 'localhost';
-        }
+        $host = $this->resolveHostName();
 
         $isSecure = (!empty($_SERVER['HTTPS'])) && ($_SERVER['HTTPS'] !== 'off')
             || isset($_SERVER['HTTP_X_FORWARDED_PROTO']) && ($_SERVER['HTTP_X_FORWARDED_PROTO'] === 'https');
@@ -278,6 +272,23 @@ public function getHostUrl()
         return  $url;
     }
 
+    /**
+     * Resolve hostname
+     *
+     * @return string
+     */
+    private function resolveHostName() : string
+    {
+        if (!empty($_SERVER['HTTP_HOST'])) {
+            $host = $_SERVER['HTTP_HOST'];
+        } elseif (!empty($_SERVER['SERVER_NAME'])) {
+            $host = $_SERVER['SERVER_NAME'];
+        } else {
+            $host = 'localhost';
+        }
+        return $host;
+    }
+
     /**
      * Retrieve base URL
      *