Skip to content

Commit a8d8440

Browse files
committed
ACP2E-3998: [Cloud]Magento OOTB code - Email Template Setup issue
1 parent dd738d0 commit a8d8440

File tree

3 files changed

+36
-10
lines changed

3 files changed

+36
-10
lines changed

app/code/Magento/CatalogWidget/Test/Unit/Block/Product/Widget/ConditionsTest.php

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,10 @@
2525
use Magento\Framework\View\TemplateEngineInterface;
2626
use Magento\Framework\View\TemplateEnginePool;
2727
use Magento\Rule\Model\Condition\Combine;
28+
use Magento\Store\Api\Data\StoreInterface;
29+
use Magento\Store\Model\StoreManagerInterface;
2830
use Magento\Widget\Model\Widget\Instance;
31+
use PHPUnit\Framework\MockObject\Exception;
2932
use PHPUnit\Framework\MockObject\MockObject;
3033
use PHPUnit\Framework\TestCase;
3134

@@ -196,9 +199,9 @@ public function testConstructWithParamsFromBlock()
196199

197200
/**
198201
* @return void
199-
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
202+
* @throws Exception
200203
*/
201-
public function testRender()
204+
public function testRender(): void
202205
{
203206
$data = ['area' => 'backend'];
204207
$abstractElementMock = $this->getMockBuilder(AbstractElement::class)
@@ -226,6 +229,10 @@ public function testRender()
226229
$templateEngineMock->expects($this->once())->method('render')->willReturn('html');
227230
$resolverMock->method('getTemplateFileName')->willReturn('');
228231

232+
$storeMock = $this->createMock(StoreInterface::class);
233+
$storeManager = $this->createMock(StoreManagerInterface::class);
234+
$storeManager->expects($this->once())->method('getStore')->willReturn($storeMock);
235+
$this->contextMock->expects($this->any())->method('getStoreManager')->willReturn($storeManager);
229236
$this->widgetConditions = $this->objectManagerHelper->getObject(
230237
Conditions::class,
231238
[

app/code/Magento/Email/Test/Unit/Block/Adminhtml/Template/EditTest.php

Lines changed: 23 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,14 @@
11
<?php
22
/**
3-
* Copyright © Magento, Inc. All rights reserved.
4-
* See COPYING.txt for license details.
3+
* Copyright 2013 Adobe
4+
* All Rights Reserved.
55
*/
66
declare(strict_types=1);
77

88
namespace Magento\Email\Test\Unit\Block\Adminhtml\Template;
99

10+
use Magento\Backend\Block\Template\Context;
11+
use Magento\Backend\Model\Menu\Item\Factory;
1012
use Magento\Backend\Helper\Data;
1113
use Magento\Backend\Model\Menu;
1214
use Magento\Backend\Model\Menu\Config;
@@ -21,9 +23,11 @@
2123
use Magento\Framework\App\Filesystem\DirectoryList;
2224
use Magento\Framework\Filesystem;
2325
use Magento\Framework\Filesystem\Directory\Read;
26+
use Magento\Framework\Serialize\SerializerInterface;
2427
use Magento\Framework\TestFramework\Unit\Helper\ObjectManager;
2528
use Magento\Framework\View\FileSystem as FilesystemView;
2629
use Magento\Framework\View\Layout;
30+
use Magento\Store\Model\StoreManagerInterface;
2731
use PHPUnit\Framework\MockObject\MockObject;
2832
use PHPUnit\Framework\TestCase;
2933
use Psr\Log\LoggerInterface;
@@ -62,6 +66,11 @@ class EditTest extends TestCase
6266
*/
6367
protected $filesystemMock;
6468

69+
/**
70+
* @var Context|MockObject
71+
*/
72+
private Context $context;
73+
6574
protected function setUp(): void
6675
{
6776
$objectManager = new ObjectManager($this);
@@ -72,8 +81,14 @@ protected function setUp(): void
7281
$helperMock = $this->createMock(Data::class);
7382
$menuConfigMock = $this->createMock(Config::class);
7483
$menuMock = $this->getMockBuilder(Menu::class)
75-
->setConstructorArgs([$this->getMockForAbstractClass(LoggerInterface::class)])
76-
->getMock();
84+
->setConstructorArgs(
85+
[
86+
$this->getMockForAbstractClass(LoggerInterface::class),
87+
'',
88+
$this->createMock(Factory::class),
89+
$this->createMock(SerializerInterface::class)
90+
]
91+
)->getMock();
7792
$menuItemMock = $this->createMock(Item::class);
7893
$urlBuilder = $this->createMock(Url::class);
7994
$this->_configStructureMock = $this->createMock(Structure::class);
@@ -96,6 +111,9 @@ protected function setUp(): void
96111
)->willReturn(
97112
DirectoryList::ROOT . '/custom/filename.phtml'
98113
);
114+
$this->context = $this->createMock(Context::class);
115+
$this->context->expects($this->any())->method('getStoreManager')
116+
->willReturn($this->createMock(StoreManagerInterface::class));
99117

100118
$params = [
101119
'urlBuilder' => $urlBuilder,
@@ -105,6 +123,7 @@ protected function setUp(): void
105123
'emailConfig' => $this->_emailConfigMock,
106124
'filesystem' => $this->filesystemMock,
107125
'viewFileSystem' => $viewFilesystem,
126+
'context' => $this->context
108127
];
109128
$arguments = $objectManager->getConstructArguments(
110129
Edit::class,

lib/internal/Magento/Framework/View/Element/Template.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<?php
22
/**
3-
* Copyright © Magento, Inc. All rights reserved.
4-
* See COPYING.txt for license details.
3+
* Copyright 2011 Adobe
4+
* All Rights Reserved.
55
*/
66
namespace Magento\Framework\View\Element;
77

@@ -35,7 +35,7 @@ class Template extends AbstractBlock
3535
/**
3636
* Config path to 'Allow Symlinks' template settings
3737
*/
38-
const XML_PATH_TEMPLATE_ALLOW_SYMLINK = 'dev/template/allow_symlink';
38+
public const XML_PATH_TEMPLATE_ALLOW_SYMLINK = 'dev/template/allow_symlink';
3939

4040
/**
4141
* Assigned variables for view
@@ -211,7 +211,7 @@ public function getTemplateFile($template = null)
211211
if ($area) {
212212
$params['area'] = $area;
213213
}
214-
$params['store_id'] = $this->_storeManager->getStore()->getId();
214+
$params['store_id'] = $this->_storeManager->getStore()?->getId();
215215
return $this->resolver->getTemplateFileName($template ?: $this->getTemplate(), $params);
216216
}
217217

0 commit comments

Comments
 (0)