move type cast from Escaper to RouteParamsResolver and add type hints

Author: tufahu

lib/internal/Magento/Framework/Escaper.php

@@ -289,9 +289,9 @@ public function escapeUrl($string)
      * @return string
      * @since 101.0.0
      */
-    public function encodeUrlParam($string)
+    public function encodeUrlParam(string $string): string
     {
-        return $this->getEscaper()->escapeUrl((string)$string);
+        return $this->getEscaper()->escapeUrl($string);
     }
 
     /**
@@ -328,9 +328,9 @@ function ($matches) {
      * @return string
      * @since 101.0.0
      */
-    public function escapeCss($string)
+    public function escapeCss(string $string): string
     {
-        return $this->getEscaper()->escapeCss((string)$string);
+        return $this->getEscaper()->escapeCss($string);
     }
 
     /**

lib/internal/Magento/Framework/Test/Unit/EscaperTest.php

@@ -384,10 +384,6 @@ public function testEscapeCss($data, string $expected): void
     public function escapeCssDataProvider(): array
     {
         return [
-            [
-                'data'     => 1,
-                'expected' => '1',
-            ],
             [
                 'data'     => '*%string{foo}%::',
                 'expected' => '\2A \25 string\7B foo\7D \25 \3A \3A ',
@@ -422,14 +418,6 @@ public function encodeUrlParamDataProvider(): array
             [
                 'data'     => "example string",
                 'expected' => "example%20string",
-            ],
-            [
-                'data'     => 1,
-                'expected' => "1",
-            ],
-            [
-                'data'     => null,
-                'expected' => "",
             ]
         ];
     }

lib/internal/Magento/Framework/Url/RouteParamsResolver.php

@@ -112,7 +112,7 @@ public function setRouteParams(array $data, $unsetOldParams = true)
             } else {
                 $this->setRouteParam(
                     $this->getEscaper()->encodeUrlParam($key),
-                    $this->getEscaper()->encodeUrlParam($value)
+                    $this->getEscaper()->encodeUrlParam((string)$value)
                 );
             }
         }