ACP2E-3324: added admin save data validator to cli set data

Author: alzota

app/code/Magento/Theme/Model/Design/Config/Validator.php

@@ -66,6 +66,9 @@ public function validate(DesignConfigInterface $designConfig)
 
         foreach ($elements as $name => $data) {
             $templateId = $data['value'];
+            if (!$templateId) {
+                continue;
+            }
             $text = $this->getTemplateText($templateId, $designConfig);
             // Check if template body has a reference to the same config path
             if (preg_match_all(Template::CONSTRUCTION_TEMPLATE_PATTERN, $text, $constructions, PREG_SET_ORDER)) {

app/code/Magento/Theme/Plugin/DesignProcessorFacade.php

@@ -0,0 +1,60 @@
+<?php
+/**
+ * Copyright 2024 Adobe
+ * All Rights Reserved.
+ */
+declare(strict_types=1);
+
+namespace Magento\Theme\Plugin;
+
+use Magento\Config\Console\Command\ConfigSet\ProcessorFacade;
+use Magento\Framework\Config\File\ConfigFilePool;
+use Magento\Framework\Exception\LocalizedException;
+use Magento\Theme\Model\Data\Design\ConfigFactory;
+use Magento\Theme\Model\Design\Config\Validator;
+
+class DesignProcessorFacade
+{
+    /**
+     * @param Validator $validator
+     * @param ConfigFactory $configFactory
+     */
+    public function __construct(
+        private Validator $validator,
+        private ConfigFactory $configFactory
+    ) {
+    }
+
+    /**
+     * Plugin to validate design configuration data before saving
+     *
+     * @param ProcessorFacade $subject
+     * @param string $path
+     * @param string $value
+     * @param string $scope
+     * @param string $scopeCode
+     * @param bool $lock
+     * @param string $lockTarget
+     * @return string
+     * @throws LocalizedException
+     * @SuppressWarnings(PHPMD.UnusedFormalParameter)
+     */
+    public function beforeProcessWithLockTarget(
+        ProcessorFacade $subject,
+        $path,
+        $value,
+        $scope,
+        $scopeCode,
+        $lock,
+        $lockTarget = ConfigFilePool::APP_ENV
+    ) {
+        if (stripos($path, 'design/') === 0) {
+            $savePath = str_replace('design/', '', $path);
+            $savePath = str_replace('/', '_', $savePath);
+            $designConfig = $this->configFactory->create($scope, $scopeCode, [$savePath => $value]);
+            $this->validator->validate($designConfig);
+        }
+
+        return [$path, $value, $scope, $scopeCode, $lock, $lockTarget];
+    }
+}

app/code/Magento/Theme/etc/adminhtml/di.xml

@@ -33,12 +33,8 @@
             </argument>
         </arguments>
     </type>
-    <type name="Magento\Theme\Model\Design\Config\Validator">
-        <arguments>
-            <argument name="fields" xsi:type="array">
-                <item name="header" xsi:type="string">email_header_template</item>
-                <item name="footer" xsi:type="string">email_footer_template</item>
-            </argument>
-        </arguments>
+    <type name="Magento\Config\Console\Command\ConfigSet\ProcessorFacade">
+        <plugin name="validate_design_config"
+                type="Magento\Theme\Plugin\DesignProcessorFacade"/>
     </type>
 </config>

app/code/Magento/Theme/etc/di.xml

@@ -334,6 +334,14 @@
     <type name="Magento\Config\Console\Command\LocaleEmulator">
         <plugin name="themeForLocaleEmulator" type="Magento\Theme\Plugin\LocaleEmulator"/>
     </type>
+    <type name="Magento\Theme\Model\Design\Config\Validator">
+        <arguments>
+            <argument name="fields" xsi:type="array">
+                <item name="header" xsi:type="string">email_header_template</item>
+                <item name="footer" xsi:type="string">email_footer_template</item>
+            </argument>
+        </arguments>
+    </type>
     <type name="Magento\Config\Console\Command\ConfigSet\ProcessorFacade">
         <arguments>
             <argument name="pathValidator" xsi:type="object">Magento\Theme\Model\Config\PathValidator</argument>