Skip to content

Commit a79847c

Browse files
kate-kyzymakate-kyzyma
committed
Adding comments for deleted StepKeys
1 parent 94c8892 commit a79847c

File tree

2 files changed

+58
-7
lines changed

2 files changed

+58
-7
lines changed

‎app/code/Magento/Catalog/Test/Mftf/Test/AdminUpdateTopCategoryUrlWithNoRedirectTest.xml

Lines changed: 28 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -44,30 +44,54 @@
4444

4545
<!-- Open 3rd Level category -->
4646
<actionGroup ref="AdminExpandCategoryTreeActionGroup" stepKey="clickOnExpandTree"/>
47-
<actionGroup ref="AdminCategoriesOpenCategoryActionGroup" stepKey="openCategory">
47+
<actionGroup ref="AdminCategoriesOpenCategoryActionGroup" stepKey="selectCategory">
4848
<argument name="category" value="$$createThreeLevelNestedCategories$$"/>
4949
</actionGroup>
50+
<comment userInput="Comment is added to preserve the step key for backward compatibility" stepKey="waitForPageToLoad"/>
5051

5152
<!--Update category UrlKey and uncheck permanent redirect for old URL -->
52-
<actionGroup ref="AdminUncheckPermanentRedirectCheckBoxActionGroup" stepKey="changeSeoUrlKey">
53+
<comment userInput="Comment is added to preserve the step key for backward compatibility" stepKey="scrollToSearchEngineOptimization1"/>
54+
<comment userInput="Comment is added to preserve the step key for backward compatibility" stepKey="selectSearchEngineOptimization"/>
55+
<comment userInput="Comment is added to preserve the step key for backward compatibility" stepKey="waitForPageToLoad1"/>
56+
<actionGroup ref="AdminUncheckPermanentRedirectCheckBoxActionGroup" stepKey="updateUrlKey">
5357
<argument name="value" value="updatedurl"/>
5458
</actionGroup>
55-
<actionGroup ref="AssertAdminCategorySaveSuccessMessageActionGroup" stepKey="assertSuccessMessage"/>
59+
<comment userInput="Comment is added to preserve the step key for backward compatibility" stepKey="uncheckPermanentRedirectCheckBox"/>
60+
<comment userInput="Comment is added to preserve the step key for backward compatibility" stepKey="selectSearchEngineOptimization1"/>
61+
<comment userInput="Comment is added to preserve the step key for backward compatibility" stepKey="saveUpdatedCategory"/>
62+
<actionGroup ref="AssertAdminCategorySaveSuccessMessageActionGroup" stepKey="seeSuccessMessage"/>
5663

5764
<!-- Get Category Id -->
5865
<grabFromCurrentUrl stepKey="categoryId" regex="#\/([0-9]*)?\/$#"/>
5966

67+
<comment userInput="Comment is added to preserve the step key for backward compatibility" stepKey="openUrlRewriteIndexPage"/>
68+
<comment userInput="Comment is added to preserve the step key for backward compatibility" stepKey="waitForUrlRewritePage"/>
6069
<!-- Verify third level category's Redirect Path, Target Path and Redirect Type after the URL Update -->
70+
<comment userInput="Comment is added to preserve the step key for backward compatibility" stepKey="clickOnResetButton"/>
71+
<comment userInput="Comment is added to preserve the step key for backward compatibility" stepKey="waitForPageToLoad0"/>
72+
<comment userInput="Comment is added to preserve the step key for backward compatibility" stepKey="openUrlRewriteGridFilters"/>
73+
<comment userInput="Comment is added to preserve the step key for backward compatibility" stepKey="fillUpdatedUrlInRedirectPathFilter"/>
74+
<comment userInput="Comment is added to preserve the step key for backward compatibility" stepKey="clickOrderApplyFilters"/>
75+
<comment userInput="Comment is added to preserve the step key for backward compatibility" stepKey="waitForPageToLoad2"/>
76+
<comment userInput="Comment is added to preserve the step key for backward compatibility" stepKey="seeTheRedirectType"/>
77+
<comment userInput="Comment is added to preserve the step key for backward compatibility" stepKey="seeTheTargetPath"/>
78+
<comment userInput="Comment is added to preserve the step key for backward compatibility" stepKey="seeTheRedirectPath"/>
6179
<actionGroup ref="AdminSearchByRequestPathActionGroup" stepKey="searchByRequestPath">
6280
<argument name="redirectPath" value="$$createDefaultCategory.name$$/$$createTwoLevelNestedCategories.name$$/updatedurl.html" />
6381
<argument name="redirectType" value="No" />
6482
<argument name="targetPath" value="catalog/category/view/id/{$categoryId}"/>
6583
</actionGroup>
6684

6785
<!-- Verify third level category's old URL path doesn't show redirect path-->
86+
<comment userInput="Comment is added to preserve the step key for backward compatibility" stepKey="clickOnResetButton1"/>
87+
<comment userInput="Comment is added to preserve the step key for backward compatibility" stepKey="waitForPageToLoad3"/>
6888
<actionGroup ref="AdminSearchDeletedUrlRewriteActionGroup" stepKey="searcOldUrlRewriteInGrid">
6989
<argument name="requestPath" value="{{Three_nested_categories.name_lwr}}"/>
7090
</actionGroup>
71-
91+
<comment userInput="Comment is added to preserve the step key for backward compatibility" stepKey="openUrlRewriteGridFilters1"/>
92+
<comment userInput="Comment is added to preserve the step key for backward compatibility" stepKey="fillOldUrlInRedirectPathFilter"/>
93+
<comment userInput="Comment is added to preserve the step key for backward compatibility" stepKey="clickOrderApplyFilters1"/>
94+
<comment userInput="Comment is added to preserve the step key for backward compatibility" stepKey="waitForPageToLoad4"/>
95+
<comment userInput="Comment is added to preserve the step key for backward compatibility" stepKey="seeEmptyRecodsMessage"/>
7296
</test>
7397
</tests>

‎app/code/Magento/Catalog/Test/Mftf/Test/AdminUpdateTopCategoryUrlWithRedirectTest.xml

Lines changed: 30 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -42,27 +42,54 @@
4242

4343
<!-- Open 3rd Level category -->
4444
<actionGroup ref="AdminExpandCategoryTreeActionGroup" stepKey="clickOnExpandTree"/>
45-
<actionGroup ref="AdminCategoriesOpenCategoryActionGroup" stepKey="openCategory">
45+
<actionGroup ref="AdminCategoriesOpenCategoryActionGroup" stepKey="selectCategory">
4646
<argument name="category" value="$$createThreeLevelNestedCategories$$"/>
4747
</actionGroup>
48+
<comment userInput="Comment is added to preserve the step key for backward compatibility" stepKey="waitForPageToLoad"/>
4849

4950
<!--Update category UrlKey and check permanent redirect for old URL -->
50-
<actionGroup ref="AdminSelectPermanentRedirectCheckBoxActionGroup" stepKey="changeSeoUrlKey">
51+
<comment userInput="Comment is added to preserve the step key for backward compatibility" stepKey="scrollToSearchEngineOptimization1"/>
52+
<comment userInput="Comment is added to preserve the step key for backward compatibility" stepKey="selectSearchEngineOptimization"/>
53+
<comment userInput="Comment is added to preserve the step key for backward compatibility" stepKey="waitForPageToLoad1"/>
54+
<actionGroup ref="AdminSelectPermanentRedirectCheckBoxActionGroup" stepKey="updateUrlKey">
5155
<argument name="value" value="updateredirecturl"/>
5256
</actionGroup>
53-
<actionGroup ref="AssertAdminCategorySaveSuccessMessageActionGroup" stepKey="assertSuccessMessage"/>
57+
<comment userInput="Comment is added to preserve the step key for backward compatibility" stepKey="checkPermanentRedirectCheckBox"/>
58+
<comment userInput="Comment is added to preserve the step key for backward compatibility" stepKey="selectSearchEngineOptimization1"/>
59+
<comment userInput="Comment is added to preserve the step key for backward compatibility" stepKey="saveUpdatedCategory"/>
60+
<actionGroup ref="AssertAdminCategorySaveSuccessMessageActionGroup" stepKey="seeSuccessMessage"/>
5461

5562
<!-- Get Category ID -->
5663
<grabFromCurrentUrl stepKey="categoryId" regex="#\/([0-9]*)?\/$#"/>
5764

65+
<comment userInput="Comment is added to preserve the step key for backward compatibility" stepKey="openUrlRewriteIndexPage"/>
66+
<comment userInput="Comment is added to preserve the step key for backward compatibility" stepKey="waitForUrlRewritePage"/>
5867
<!-- Verify third level category's Redirect Path, Target Path and Redirect Type for updated URL-->
68+
<comment userInput="Comment is added to preserve the step key for backward compatibility" stepKey="clickOnResetButton"/>
69+
<comment userInput="Comment is added to preserve the step key for backward compatibility" stepKey="waitForPageToLoad2"/>
70+
<comment userInput="Comment is added to preserve the step key for backward compatibility" stepKey="openUrlRewriteGridFilters"/>
71+
<comment userInput="Comment is added to preserve the step key for backward compatibility" stepKey="fillUpdatedURLInRedirectPathFilter"/>
72+
<comment userInput="Comment is added to preserve the step key for backward compatibility" stepKey="clickOrderApplyFilters"/>
73+
<comment userInput="Comment is added to preserve the step key for backward compatibility" stepKey="waitForPageToLoad3"/>
74+
<comment userInput="Comment is added to preserve the step key for backward compatibility" stepKey="seeTheRedirectType"/>
75+
<comment userInput="Comment is added to preserve the step key for backward compatibility" stepKey="seeTheTargetPath"/>
76+
<comment userInput="Comment is added to preserve the step key for backward compatibility" stepKey="seeTheRedirectPath"/>
5977
<actionGroup ref="AdminSearchByRequestPathActionGroup" stepKey="searchByRequestPath">
6078
<argument name="redirectPath" value="$$createDefaultCategory.name$$/$$createTwoLevelNestedCategories.name$$/updateredirecturl.html" />
6179
<argument name="redirectType" value="No" />
6280
<argument name="targetPath" value="catalog/category/view/id/{$categoryId}"/>
6381
</actionGroup>
6482

6583
<!-- Verify third level category's Redirect path, Target Path and Redirect type for old URL -->
84+
<comment userInput="Comment is added to preserve the step key for backward compatibility" stepKey="clickOnResetButton1"/>
85+
<comment userInput="Comment is added to preserve the step key for backward compatibility" stepKey="waitForPageToLoad4"/>
86+
<comment userInput="Comment is added to preserve the step key for backward compatibility" stepKey="openUrlRewriteGridFilters1"/>
87+
<comment userInput="Comment is added to preserve the step key for backward compatibility" stepKey="fillOldUrlInRedirectPathFilter"/>
88+
<comment userInput="Comment is added to preserve the step key for backward compatibility" stepKey="clickOrderApplyFilters1"/>
89+
<comment userInput="Comment is added to preserve the step key for backward compatibility" stepKey="waitForPageToLoad5"/>
90+
<comment userInput="Comment is added to preserve the step key for backward compatibility" stepKey="seeTheRedirectPathForOldUrl"/>
91+
<comment userInput="Comment is added to preserve the step key for backward compatibility" stepKey="seeTheTargetPathForOldUrl"/>
92+
<comment userInput="Comment is added to preserve the step key for backward compatibility" stepKey="seeTheRedirectTypeForOldUrl"/>
6693
<actionGroup ref="AdminSearchByRequestPathActionGroup" stepKey="searchByRequestPathForOldUrl">
6794
<argument name="redirectPath" value="$$createDefaultCategory.name$$/$$createTwoLevelNestedCategories.name$$/$$createThreeLevelNestedCategories.name$$.html" />
6895
<argument name="redirectType" value="Permanent (301)" />

0 commit comments

Comments
 (0)