Skip to content

Commit a72edc6

Browse files
committed
ACP2E-2679: Updating time of Date and Time type product attributes via CSV import
1 parent 564a787 commit a72edc6

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

app/code/Magento/ImportExport/Api/Data/FieldsEnclosureAwareExportInfoInterface.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,13 +25,13 @@ interface FieldsEnclosureAwareExportInfoInterface extends LocalizedExportInfoInt
2525
*
2626
* @return bool|null
2727
*/
28-
public function getFieldsEnclosure();
28+
public function getFieldsEnclosure(): ?bool;
2929

3030
/**
3131
* Set whether fields enclosure is enabled
3232
*
3333
* @param bool $fieldsEnclosure
3434
* @return void
3535
*/
36-
public function setFieldsEnclosure($fieldsEnclosure);
36+
public function setFieldsEnclosure(bool $fieldsEnclosure): void;
3737
}

app/code/Magento/ImportExport/Model/Export/Entity/ExportInfo.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -172,15 +172,15 @@ public function setLocale(string $locale): void
172172
/**
173173
* @inheritDoc
174174
*/
175-
public function getFieldsEnclosure()
175+
public function getFieldsEnclosure(): ?bool
176176
{
177177
return $this->fieldsEnclosure;
178178
}
179179

180180
/**
181181
* @inheritDoc
182182
*/
183-
public function setFieldsEnclosure($fieldsEnclosure)
183+
public function setFieldsEnclosure(bool $fieldsEnclosure): void
184184
{
185185
$this->fieldsEnclosure = $fieldsEnclosure;
186186
}

app/code/Magento/ImportExport/Model/Export/Entity/ExportInfoFactory.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -107,8 +107,8 @@ public function create(
107107
$writer->getContentType()
108108
);
109109
$fileName = $this->generateFileName($entity, $entityAdapter, $writer->getFileExtension());
110-
/** @var ExportInfoInterface $exportInfo */
111-
$exportInfo = $this->objectManager->create(ExportInfoInterface::class);
110+
/** @var FieldsEnclosureAwareExportInfoInterface $exportInfo */
111+
$exportInfo = $this->objectManager->create(FieldsEnclosureAwareExportInfoInterface::class);
112112
$exportInfo->setExportFilter($this->serializer->serialize($exportFilter));
113113
$exportInfo->setSkipAttr($skipAttr);
114114
$exportInfo->setFileName($fileName);
@@ -118,7 +118,7 @@ public function create(
118118
if ($locale) {
119119
$exportInfo->setLocale($locale);
120120
}
121-
if ($exportInfo instanceof FieldsEnclosureAwareExportInfoInterface && $fieldsEnclosure !== null) {
121+
if ($fieldsEnclosure !== null) {
122122
$exportInfo->setFieldsEnclosure($fieldsEnclosure);
123123
}
124124

0 commit comments

Comments
 (0)