🔃 [Magento Community Engineering] Community Contributions - 2.3-develop expedited

Accepted Community Pull Requests:
 - #23477: Added quantity validation on Shipping Multiple Address Page (by @nirmalraval18)
 - #23494: Removed editor from phone and zipcode (by @kazim-krish)
 - #23474: Fixed tooltip missing at store view lable in Cms page and Cms block (by @dipeshrangani)
 - #21128: Fix issue 21126 : Import design break issue resolved (by @speedy008)
 - #23457: Update CartTotalRepository.php (by @UlyanaKiklevich)
 - #22213: Date column ui component locale date format (by @Karlasa)


Fixed GitHub Issues:
 - #23466: Cart empty after update qty with -1 and change address. (reported by @nirmalraval18) has been fixed in #23477 by @nirmalraval18 in 2.3-develop branch
   Related commits:
     1. 6735bc5

 - #23467: Phone and Zip not update if customer have no saved address (reported by @vrajesh-patel1993) has been fixed in #23494 by @kazim-krish in 2.3-develop branch
   Related commits:
     1. 2d7d8a8
     2. 11b1c2b

 - #23471: Tooltip missing at store view lable in Cms page and Cms block (reported by @dipeshrangani) has been fixed in #23474 by @dipeshrangani in 2.3-develop branch
   Related commits:
     1. 5a0c19d

 - #21126: Backend Import behavior  design break (reported by @speedy008) has been fixed in #21128 by @speedy008 in 2.3-develop branch
   Related commits:
     1. eebd15f
     2. c8dba0b
     3. d0d5615

Author: magento-engcom-team

app/code/Magento/Cms/view/adminhtml/ui_component/cms_block_form.xml

@@ -123,6 +123,10 @@
                     <rule name="required-entry" xsi:type="boolean">true</rule>
                 </validation>
                 <dataType>int</dataType>
+                <tooltip>
+                    <link>https://docs.magento.com/m2/ce/user_guide/configuration/scope.html</link>
+                    <description>What is this?</description>
+                </tooltip>
                 <label translate="true">Store View</label>
                 <dataScope>store_id</dataScope>
             </settings>

app/code/Magento/Cms/view/adminhtml/ui_component/cms_page_form.xml

@@ -207,6 +207,10 @@
                     <rule name="required-entry" xsi:type="boolean">true</rule>
                 </validation>
                 <dataType>int</dataType>
+                <tooltip>
+                    <link>https://docs.magento.com/m2/ce/user_guide/configuration/scope.html</link>
+                    <description>What is this?</description>
+                </tooltip>
                 <label translate="true">Store View</label>
                 <dataScope>store_id</dataScope>
             </settings>

app/code/Magento/Customer/view/adminhtml/ui_component/customer_listing.xml

@@ -157,18 +157,12 @@
         <column name="billing_telephone" sortOrder="60">
             <settings>
                 <filter>text</filter>
-                <editor>
-                    <editorType>text</editorType>
-                </editor>
                 <label translate="true">Phone</label>
             </settings>
         </column>
         <column name="billing_postcode" sortOrder="70">
             <settings>
                 <filter>text</filter>
-                <editor>
-                    <editorType>text</editorType>
-                </editor>
                 <label translate="true">ZIP</label>
             </settings>
         </column>
@@ -269,59 +263,41 @@
         <column name="billing_city" sortOrder="210">
             <settings>
                 <filter>text</filter>
-                <editor>
-                    <editorType>text</editorType>
-                </editor>
                 <label translate="true">City</label>
                 <visible>false</visible>
             </settings>
         </column>
         <column name="billing_fax" sortOrder="220">
             <settings>
                 <filter>text</filter>
-                <editor>
-                    <editorType>text</editorType>
-                </editor>
                 <label translate="true">Fax</label>
                 <visible>false</visible>
             </settings>
         </column>
         <column name="billing_vat_id" sortOrder="230">
             <settings>
                 <filter>text</filter>
-                <editor>
-                    <editorType>text</editorType>
-                </editor>
                 <label translate="true">VAT Number</label>
                 <visible>false</visible>
             </settings>
         </column>
         <column name="billing_company" sortOrder="240">
             <settings>
                 <filter>text</filter>
-                <editor>
-                    <editorType>text</editorType>
-                </editor>
                 <label translate="true">Company</label>
                 <visible>false</visible>
             </settings>
         </column>
         <column name="billing_firstname" sortOrder="250">
             <settings>
                 <filter>text</filter>
-                <editor>
-                    <editorType>text</editorType>
-                </editor>
                 <label translate="true">Billing Firstname</label>
                 <visible>false</visible>
             </settings>
         </column>
         <column name="billing_lastname" sortOrder="260">
             <settings>
                 <filter>text</filter>
-                <editor>
-                    <editorType>text</editorType>
-                </editor>
                 <label translate="true">Billing Lastname</label>
                 <visible>false</visible>
             </settings>

app/code/Magento/Multishipping/view/frontend/templates/checkout/addresses.phtml

@@ -62,8 +62,9 @@
                                            name="ship[<?= $block->escapeHtml($_index) ?>][<?= $block->escapeHtml($_item->getQuoteItemId()) ?>][qty]"
                                            value="<?= $block->escapeHtml($_item->getQty()) ?>"
                                            size="2"
+                                           min="0"
                                            class="input-text qty"
-                                           data-validate="{number: true}"/>
+                                           data-validate="{number: true,'validate-greater-than-zero':true}"/>
                                 </div>
                             </div>
                         </td>

app/code/Magento/Quote/Model/Cart/CartTotalRepository.php

@@ -8,7 +8,6 @@
 use Magento\Quote\Api;
 use Magento\Quote\Api\CartRepositoryInterface;
 use Magento\Quote\Api\CartTotalRepositoryInterface;
-use Magento\Catalog\Helper\Product\ConfigurationPool;
 use Magento\Framework\Api\DataObjectHelper;
 use Magento\Framework\Api\ExtensibleDataInterface;
 use Magento\Quote\Model\Cart\Totals\ItemConverter;
@@ -40,7 +39,7 @@ class CartTotalRepository implements CartTotalRepositoryInterface
     private $dataObjectHelper;
 
     /**
-     * @var ConfigurationPool
+     * @var ItemConverter
      */
     private $itemConverter;
 

app/code/Magento/Ui/view/base/web/js/grid/columns/date.js

@@ -26,7 +26,7 @@ define([
         initConfig: function () {
             this._super();
 
-            this.dateFormat = utils.normalizeDate(this.dateFormat);
+            this.dateFormat = utils.normalizeDate(this.dateFormat ? this.dateFormat : this.options.dateFormat);
 
             return this;
         },

lib/web/mage/validation.js

@@ -1888,6 +1888,10 @@
                 if (element.siblings('.tooltip').length) {
                     errorPlacement = element.siblings('.tooltip');
                 }
+                //logic for select with tooltip in after element
+                if (element.next().find('.tooltip').length) {
+                    errorPlacement = element.next();
+                }
                 errorPlacement.after(error);
             }
         },