Skip to content

Commit a6f1fb8

Browse files
author
Oleksii Korshenko
authored
MAGETWO-87035: Fix misspellings in method names and deprecate old ones #13304
2 parents 273c4d6 + f0fbc43 commit a6f1fb8

File tree

5 files changed

+23
-5
lines changed

5 files changed

+23
-5
lines changed

app/code/Magento/Eav/Block/Adminhtml/Attribute/Edit/Js.php

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,12 +36,21 @@ public function __construct(
3636
parent::__construct($context, $data);
3737
}
3838

39+
/**
40+
* @deprecated Misspelled method
41+
* @see getCompatibleInputTypes
42+
*/
43+
public function getComaptibleInputTypes()
44+
{
45+
return $this->getCompatibleInputTypes();
46+
}
47+
3948
/**
4049
* Get compatible input types.
4150
*
4251
* @return array
4352
*/
44-
public function getComaptibleInputTypes()
53+
public function getCompatibleInputTypes()
4554
{
4655
return $this->inputtype->getVolatileInputTypes();
4756
}

app/code/Magento/Review/Controller/Adminhtml/Rating.php

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,9 +41,18 @@ public function __construct(
4141
}
4242

4343
/**
44-
* @return void
44+
* @deprecated Misspelled method
45+
* @see initEntityId
4546
*/
4647
protected function initEnityId()
48+
{
49+
$this->initEntityId();
50+
}
51+
52+
/**
53+
* @return void
54+
*/
55+
protected function initEntityId()
4756
{
4857
$this->coreRegistry->register(
4958
'entityId',

app/code/Magento/Review/Controller/Adminhtml/Rating/Edit.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ class Edit extends RatingController
1515
*/
1616
public function execute()
1717
{
18-
$this->initEnityId();
18+
$this->initEntityId();
1919
/** @var \Magento\Review\Model\Rating $ratingModel */
2020
$ratingModel = $this->_objectManager->create(\Magento\Review\Model\Rating::class);
2121
if ($this->getRequest()->getParam('id')) {

app/code/Magento/Review/Controller/Adminhtml/Rating/Index.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ class Index extends RatingController
1515
*/
1616
public function execute()
1717
{
18-
$this->initEnityId();
18+
$this->initEntityId();
1919
/** @var \Magento\Backend\Model\View\Result\Page $resultPage */
2020
$resultPage = $this->resultFactory->create(ResultFactory::TYPE_PAGE);
2121
$resultPage->setActiveMenu('Magento_Review::catalog_reviews_ratings_ratings');

app/code/Magento/Review/Controller/Adminhtml/Rating/Save.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ class Save extends RatingController
1717
*/
1818
public function execute()
1919
{
20-
$this->initEnityId();
20+
$this->initEntityId();
2121
/** @var \Magento\Backend\Model\View\Result\Redirect $resultRedirect */
2222
$resultRedirect = $this->resultFactory->create(ResultFactory::TYPE_REDIRECT);
2323
if ($this->getRequest()->getPostValue()) {

0 commit comments

Comments
 (0)