Skip to content

Commit a6d64f2

Browse files
manishranjan-adobemanishranjan-adobe
committed
AC-12092_PHPUnit10: Providing invalid named argument is deprecated and will not be supported in PHPUnit 11.
1 parent 1d1acab commit a6d64f2

File tree

9 files changed

+108
-108
lines changed

9 files changed

+108
-108
lines changed

‎app/code/Magento/Catalog/Test/Unit/Model/Layer/Filter/DataProvider/PriceTest.php

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -177,14 +177,14 @@ public function testValidateFilter($filter, $expectedResult)
177177
public static function validateFilterDataProvider()
178178
{
179179
return [
180-
['filter' => '0-10', 'result' => ['0', '10']],
181-
['filter' => '0-10-20', 'result' => false],
182-
['filter' => '', 'result' => false],
183-
['filter' => '-', 'result' => ['', '']],
184-
['filter' => '0', 'result' => false],
185-
['filter' => 0, 'result' => false],
186-
['filter' => '100500INF', 'result' => false],
187-
['filter' => '-10\'[0]', 'result' => false],
180+
['filter' => '0-10', 'expectedResult' => ['0', '10']],
181+
['filter' => '0-10-20', 'expectedResult' => false],
182+
['filter' => '', 'expectedResult' => false],
183+
['filter' => '-', 'expectedResult' => ['', '']],
184+
['filter' => '0', 'expectedResult' => false],
185+
['filter' => 0, 'expectedResult' => false],
186+
['filter' => '100500INF', 'expectedResult' => false],
187+
['filter' => '-10\'[0]', 'expectedResult' => false],
188188
];
189189
}
190190

‎app/code/Magento/GraphQl/Test/Unit/Plugin/DisableSessionTest.php

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -80,14 +80,14 @@ public function testAfterCheck(string $area, bool $config, bool $methodResult, b
8080
public static function testAfterCheckDataProvider()
8181
{
8282
return [
83-
['area' => 'graphql', 'config' => true, 'methodResult' => false, 'expected' => false],
84-
['area' => 'graphql', 'config' => true, 'methodResult' => true, 'expected' => false],
85-
['area' => 'graphql', 'config' => false, 'methodResult' => true, 'expected' => true],
86-
['area' => 'graphql', 'config' => false, 'methodResult' => false, 'expected' => false],
87-
['area' => 'other', 'config' => false, 'methodResult' => false, 'expected' => false],
88-
['area' => 'other', 'config' => true, 'methodResult' => false, 'expected' => false],
89-
['area' => 'other', 'config' => true, 'methodResult' => true, 'expected' => true],
90-
['area' => 'other', 'config' => false, 'methodResult' => true, 'expected' => true],
83+
['area' => 'graphql', 'config' => true, 'methodResult' => false, 'expectedResult' => false],
84+
['area' => 'graphql', 'config' => true, 'methodResult' => true, 'expectedResult' => false],
85+
['area' => 'graphql', 'config' => false, 'methodResult' => true, 'expectedResult' => true],
86+
['area' => 'graphql', 'config' => false, 'methodResult' => false, 'expectedResult' => false],
87+
['area' => 'other', 'config' => false, 'methodResult' => false, 'expectedResult' => false],
88+
['area' => 'other', 'config' => true, 'methodResult' => false, 'expectedResult' => false],
89+
['area' => 'other', 'config' => true, 'methodResult' => true, 'expectedResult' => true],
90+
['area' => 'other', 'config' => false, 'methodResult' => true, 'expectedResult' => true],
9191
];
9292
}
9393

@@ -117,10 +117,10 @@ public function testAfterCheckNoArea(bool $config, bool $methodResult, bool $exp
117117
public static function testAfterCheckDataProviderNoAreaCode()
118118
{
119119
return [
120-
['config' => true, 'methodResult' => true, 'expected' => true],
121-
['config' => true, 'methodResult' => false, 'expected' => false],
122-
['config' => false, 'methodResult' => true, 'expected' => true],
123-
['config' => false, 'methodResult' => false, 'expected' => false],
120+
['config' => true, 'methodResult' => true, 'expectedResult' => true],
121+
['config' => true, 'methodResult' => false, 'expectedResult' => false],
122+
['config' => false, 'methodResult' => true, 'expectedResult' => true],
123+
['config' => false, 'methodResult' => false, 'expectedResult' => false],
124124
];
125125
}
126126
}

‎app/code/Magento/Reports/Test/Unit/Model/ResourceModel/Report/CollectionTest.php

Lines changed: 18 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -145,39 +145,39 @@ public static function intervalsDataProvider()
145145
{
146146
return [
147147
[
148-
'_period' => 'day',
149-
'_from' => new \DateTime('-3 day'),
150-
'_to' => new \DateTime('+3 day'),
148+
'period' => 'day',
149+
'fromDate' => new \DateTime('-3 day'),
150+
'toDate' => new \DateTime('+3 day'),
151151
'size' => 7
152152
],
153153
[
154-
'_period' => 'month',
155-
'_from' => new \DateTime('2015-01-15 11:11:11'),
156-
'_to' => new \DateTime('2015-01-25 11:11:11'),
154+
'period' => 'month',
155+
'fromDate' => new \DateTime('2015-01-15 11:11:11'),
156+
'toDate' => new \DateTime('2015-01-25 11:11:11'),
157157
'size' => 1
158158
],
159159
[
160-
'_period' => 'month',
161-
'_from' => new \DateTime('2015-01-15 11:11:11'),
162-
'_to' => new \DateTime('2015-02-25 11:11:11'),
160+
'period' => 'month',
161+
'fromDate' => new \DateTime('2015-01-15 11:11:11'),
162+
'toDate' => new \DateTime('2015-02-25 11:11:11'),
163163
'size' => 2
164164
],
165165
[
166-
'_period' => 'year',
167-
'_from' => new \DateTime('2015-01-15 11:11:11'),
168-
'_to' => new \DateTime('2015-01-25 11:11:11'),
166+
'period' => 'year',
167+
'fromDate' => new \DateTime('2015-01-15 11:11:11'),
168+
'toDate' => new \DateTime('2015-01-25 11:11:11'),
169169
'size' => 1
170170
],
171171
[
172-
'_period' => 'year',
173-
'_from' => new \DateTime('2014-01-15 11:11:11'),
174-
'_to' => new \DateTime('2015-01-25 11:11:11'),
172+
'period' => 'year',
173+
'fromDate' => new \DateTime('2014-01-15 11:11:11'),
174+
'toDate' => new \DateTime('2015-01-25 11:11:11'),
175175
'size' => 2
176176
],
177177
[
178-
'_period' => null,
179-
'_from' => new \DateTime('-3 day'),
180-
'_to' => new \DateTime('+3 day'),
178+
'period' => null,
179+
'fromDate' => new \DateTime('-3 day'),
180+
'toDate' => new \DateTime('+3 day'),
181181
'size' => 0
182182
]
183183
];

‎app/code/Magento/Ui/Test/Unit/Config/Converter/ItemTest.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ protected function setUp(): void
4545
* @param string $xpath
4646
* @dataProvider convertDataProvider
4747
*/
48-
public function testConvert(array $expectedResult, $xpath)
48+
public function testConvert(array $expectedResult, string $xpath)
4949
{
5050
$node = $this->domXpath->query($xpath)->item(0);
5151
if ($xpath == '//listing/columns/settings/editorConfig') {
@@ -132,7 +132,7 @@ private static function getSetOne()
132132
private static function getSetTwo()
133133
{
134134
return [
135-
'editorConfig' => [
135+
'expectedResult' => [
136136
'name' => 'editorConfig',
137137
'xsi:type' => 'array',
138138
'item' => [
@@ -174,7 +174,7 @@ private static function getSetTwo()
174174
private static function getSetThree()
175175
{
176176
return [
177-
'templates' => [
177+
'xpath' => [
178178
'name' => 'templates',
179179
'xsi:type' => 'array',
180180
'item' => [

‎dev/tests/integration/framework/tests/unit/testsuite/Magento/Test/Annotation/AppAreaTest.php

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -185,25 +185,25 @@ public static function startTestWithDifferentAreaCodes()
185185
{
186186
return [
187187
[
188-
'area_code' => Area::AREA_GLOBAL,
188+
'areaCode' => Area::AREA_GLOBAL,
189189
],
190190
[
191-
'area_code' => Area::AREA_ADMINHTML,
191+
'areaCode' => Area::AREA_ADMINHTML,
192192
],
193193
[
194-
'area_code' => Area::AREA_FRONTEND,
194+
'areaCode' => Area::AREA_FRONTEND,
195195
],
196196
[
197-
'area_code' => Area::AREA_WEBAPI_REST,
197+
'areaCode' => Area::AREA_WEBAPI_REST,
198198
],
199199
[
200-
'area_code' => Area::AREA_WEBAPI_SOAP,
200+
'areaCode' => Area::AREA_WEBAPI_SOAP,
201201
],
202202
[
203-
'area_code' => Area::AREA_CRONTAB,
203+
'areaCode' => Area::AREA_CRONTAB,
204204
],
205205
[
206-
'area_code' => Area::AREA_GRAPHQL,
206+
'areaCode' => Area::AREA_GRAPHQL,
207207
],
208208
];
209209
}

‎dev/tests/integration/framework/tests/unit/testsuite/Magento/Test/ApplicationTest.php

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -385,19 +385,19 @@ public static function partialLoadAreaDataProvider()
385385
{
386386
return [
387387
[
388-
'area_code' => Area::AREA_GLOBAL,
388+
'areaCode' => Area::AREA_GLOBAL,
389389
],
390390
[
391-
'area_code' => Area::AREA_WEBAPI_REST,
391+
'areaCode' => Area::AREA_WEBAPI_REST,
392392
],
393393
[
394-
'area_code' => Area::AREA_WEBAPI_SOAP,
394+
'areaCode' => Area::AREA_WEBAPI_SOAP,
395395
],
396396
[
397-
'area_code' => Area::AREA_CRONTAB,
397+
'areaCode' => Area::AREA_CRONTAB,
398398
],
399399
[
400-
'area_code' => Area::AREA_GRAPHQL,
400+
'areaCode' => Area::AREA_GRAPHQL,
401401
],
402402
];
403403
}

‎dev/tests/integration/framework/tests/unit/testsuite/Magento/Test/Workaround/Override/Fixture/Applier/AdminConfigFixtureTest.php

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -47,14 +47,14 @@ public static function annotationsProvider(): array
4747
{
4848
return [
4949
'simple_record' => [
50-
'current_fixture' => 'section/group/field value',
50+
'fixture' => 'section/group/field value',
5151
'attributes' => [
5252
'path' => 'section/group/field',
5353
'value' => 'value',
5454
],
5555
],
5656
'simple_record_many_spaces' => [
57-
'current_fixture' => ' section/group/field value',
57+
'fixture' => ' section/group/field value',
5858
'attributes' => [
5959
'path' => 'section/group/field',
6060
'value' => 'value',
@@ -82,7 +82,7 @@ public static function wrongRecordsProvider(): array
8282
{
8383
return [
8484
'another_path_record' => [
85-
'current_fixture' => 'section/group/another_field value',
85+
'fixture' => 'section/group/another_field value',
8686
'attributes' => [
8787
'path' => 'section/group/field',
8888
'value' => 'value',
@@ -117,14 +117,14 @@ public static function initFixtureProvider(): array
117117
'path' => 'section/group/field',
118118
'value' => 'value',
119119
],
120-
'expected_value' => 'section/group/field value',
120+
'expectedValue' => 'section/group/field value',
121121
],
122122
'with_new_value' => [
123123
'attributes' => [
124124
'path' => 'section/group/field',
125125
'newValue' => 'new_value',
126126
],
127-
'expected_value' => 'section/group/field new_value',
127+
'expectedValue' => 'section/group/field new_value',
128128
],
129129
];
130130
}

0 commit comments

Comments
 (0)