Skip to content

Commit a6cf190

Browse files
committed
Code Review changes
1 parent 8ff0bf9 commit a6cf190

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

app/code/Magento/Backend/Block/Widget/Button/SplitButton.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -168,7 +168,7 @@ public function getToggleAttributesHtml()
168168
'title' => $title,
169169
'class' => join(' ', $classes),
170170
'disabled' => $disabled,
171-
'aria-label' => $this->getData('dropdown_button_aria_label') ?: '',
171+
'aria-label' => (string)$this->getData('dropdown_button_aria_label'),
172172
];
173173
$this->_getDataAttributes(['mage-init' => '{"dropdown": {}}', 'toggle' => 'dropdown'], $attributes);
174174

app/code/Magento/Ui/Component/Control/SplitButton.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -165,7 +165,7 @@ public function getToggleAttributesHtml()
165165
'title' => $title,
166166
'class' => join(' ', $classes),
167167
'disabled' => $disabled,
168-
'aria-label' => $this->getData('dropdown_button_aria_label') ?: '',
168+
'aria-label' => (string)$this->getData('dropdown_button_aria_label'),
169169
];
170170
$this->getDataAttributes(['mage-init' => '{"dropdown": {}}', 'toggle' => 'dropdown'], $attributes);
171171

0 commit comments

Comments
 (0)