MAGETWO-55589: Wrong algorithm for calculation batch size on category indexing

 - fixed static tests

Author: Oleksii Korshenko

lib/internal/Magento/Framework/Test/DB/Query/BatchIteratorTest.php renamed to lib/internal/Magento/Framework/Test/Unit/DB/Query/BatchIteratorTest.php

@@ -31,11 +31,31 @@ class BatchIteratorTest extends \PHPUnit_Framework_TestCase
      */
     private $connectionMock;
 
+    /**
+     * @var int
+     */
     private $batchSize;
+
+    /**
+     * @var string
+     */
     private $correlationName;
+
+    /**
+     * @var string
+     */
     private $rangeField;
+
+    /**
+     * @var string
+     */
     private $rangeFieldAlias;
 
+    /**
+     * Setup test dependencies.
+     *
+     * @return void
+     */
     protected function setUp()
     {
         $this->batchSize = 10;
@@ -64,6 +84,7 @@ protected function setUp()
      * 1. $iterator->current();
      * 2. $iterator->current();
      * 3. $iterator->key();
+     * @return void
      */
     public function testCurrent()
     {
@@ -103,7 +124,7 @@ public function testCurrent()
      *
      * 1. $iterator->next()
      * 2. $iterator->valid();
-     *
+     * @return void
      */
     public function testIterations()
     {
@@ -147,6 +168,7 @@ public function testIterations()
      * 3. $iterator->next();
      * 4. $iterator->current()
      * 5. $iterator->key()
+     * @return void
      */
     public function testNext()
     {
@@ -166,10 +188,7 @@ public function testNext()
         $this->connectionMock->expects($this->exactly(3))
             ->method('fetchRow')
             ->with($this->wrapperSelectMock)
-            ->willReturn([
-                'max' => 25,
-                'cnt' => 10
-            ]
+            ->willReturn(['max' => 25, 'cnt' => 10]
         );
 
         $this->assertEquals($this->selectMock, $this->model->next());

lib/internal/Magento/Framework/Test/DB/Query/GeneratorTest.php renamed to lib/internal/Magento/Framework/Test/Unit/DB/Query/GeneratorTest.php

@@ -32,6 +32,9 @@ class GeneratorTest extends \PHPUnit_Framework_TestCase
      */
     private $iteratorMock;
 
+    /**
+     * Setup test dependencies.
+     */
     protected function setUp()
     {
         $this->factoryMock = $this->getMock(BatchIteratorFactory::class, [], [], '', false, false);
@@ -40,6 +43,10 @@ protected function setUp()
         $this->model = new Generator($this->factoryMock);
     }
 
+    /**
+     * Test success generate.
+     * @return void
+     */
     public function testGenerate()
     {
         $map = [
@@ -70,8 +77,11 @@ public function testGenerate()
     }
 
     /**
+     * Test batch generation with invalid select object.
+     *
      * @expectedException \Magento\Framework\Exception\LocalizedException
      * @expectedExceptionMessage  Select object must have correct "FROM" part
+     * @return void
      */
     public function testGenerateWithoutFromPart()
     {
@@ -89,7 +99,11 @@ public function testGenerateWithoutFromPart()
         $this->model->generate('entity_id', $this->selectMock, 100);
     }
 
-    public function testGenerateWithInvalidRangeField()
+    /**
+     * Test generate batches with rangeField without alias.
+     * @return void
+     */
+    public function testGenerateWithRangeFieldWithoutAlias()
     {
         $map = [
             [
@@ -118,7 +132,12 @@ public function testGenerateWithInvalidRangeField()
         $this->assertEquals($this->iteratorMock, $this->model->generate('entity_id', $this->selectMock, 100));
     }
 
-    public function testGenerateWithInvalidRangeFieldValue()
+    /**
+     * Test generate batches with wild-card.
+     *
+     * @return void
+     */
+    public function testGenerateWithInvalidWithWildcard()
     {
         $map = [
             [