Skip to content

Commit a6220c0

Browse files
committed
Merge remote-tracking branch 'mainline/develop' into MAGETWO-71696
2 parents a4bdfc1 + 6c5ba1f commit a6220c0

File tree

6 files changed

+19
-6
lines changed

6 files changed

+19
-6
lines changed

app/code/Magento/Catalog/Model/Product/Gallery/Processor.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -192,6 +192,7 @@ public function addImage(
192192
$mediaGalleryData['images'][] = [
193193
'file' => $fileName,
194194
'position' => $position,
195+
'media_type' => 'image',
195196
'label' => '',
196197
'disabled' => (int)$exclude,
197198
];

app/code/Magento/Customer/i18n/en_US.csv

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -400,12 +400,12 @@ Password:,Password:
400400
"If you did not make this request, you can ignore this email and your password will remain the same.","If you did not make this request, you can ignore this email and your password will remain the same."
401401
"Your %store_name password has been changed","Your %store_name password has been changed"
402402
"We have received a request to change the following information associated with your account at %store_name: password.","We have received a request to change the following information associated with your account at %store_name: password."
403-
"Checkout out as a new customer","Checkout out as a new customer"
403+
"Checkout as a new customer","Checkout as a new customer"
404404
"Creating an account has many benefits:","Creating an account has many benefits:"
405405
"See order and shipping status","See order and shipping status"
406406
"Track order history","Track order history"
407407
"Check out faster","Check out faster"
408-
"Checkout out using your account","Checkout out using your account"
408+
"Checkout using your account","Checkout using your account"
409409
"Email Address","Email Address"
410410
"Are you sure you want to do this?","Are you sure you want to do this?"
411411
"Are you sure you want to delete this address?","Are you sure you want to delete this address?"

app/code/Magento/Customer/view/frontend/web/template/authentication-popup.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
<strong id="block-new-customer-heading"
1515
role="heading"
1616
aria-level="2"
17-
data-bind="i18n: 'Checkout out as a new customer'"></strong>
17+
data-bind="i18n: 'Checkout as a new customer'"></strong>
1818
</div>
1919
<div class="block-content" aria-labelledby="block-new-customer-heading">
2020
<p data-bind="i18n: 'Creating an account has many benefits:'"></p>
@@ -39,7 +39,7 @@
3939
<strong id="block-customer-login-heading"
4040
role="heading"
4141
aria-level="2"
42-
data-bind="i18n: 'Checkout out using your account'"></strong>
42+
data-bind="i18n: 'Checkout using your account'"></strong>
4343
</div>
4444
<!-- ko foreach: getRegion('messages') -->
4545
<!-- ko template: getTemplate() --><!-- /ko -->

app/code/Magento/Ui/Component/Listing/Columns/Date.php

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,9 @@ public function prepareDataSource(array $dataSource)
5454
{
5555
if (isset($dataSource['data']['items'])) {
5656
foreach ($dataSource['data']['items'] as & $item) {
57-
if (isset($item[$this->getData('name')])) {
57+
if (isset($item[$this->getData('name')])
58+
&& $item[$this->getData('name')] !== "0000-00-00 00:00:00"
59+
) {
5860
$date = $this->timezone->date(new \DateTime($item[$this->getData('name')]));
5961
$timezone = isset($this->getConfiguration()['timezone'])
6062
? $this->booleanUtils->convert($this->getConfiguration()['timezone'])

app/code/Magento/Ui/Test/Unit/Component/Listing/Columns/DateTest.php

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -89,4 +89,14 @@ public function testPrepareDataSource()
8989
$result = $this->model->prepareDataSource(['data' => ['items' => [$item]]]);
9090
$this->assertEquals(self::TEST_TIME, $result['data']['items'][0]['field_name']);
9191
}
92+
93+
public function testPrepareDataSourceWithZeroDate()
94+
{
95+
$zeroDate = '0000-00-00 00:00:00';
96+
$item = ['test_data' => 'some_data', 'field_name' => $zeroDate];
97+
$this->timezoneMock->expects($this->never())->method('date');
98+
99+
$result = $this->model->prepareDataSource(['data' => ['items' => [$item]]]);
100+
$this->assertEquals($zeroDate, $result['data']['items'][0]['field_name']);
101+
}
92102
}

app/code/Magento/Webapi/Controller/Rest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -303,7 +303,7 @@ protected function processSchemaRequest()
303303
$responseBody = $this->swaggerGenerator->generate(
304304
$requestedServices,
305305
$this->_request->getScheme(),
306-
$this->_request->getHttpHost(),
306+
$this->_request->getHttpHost(false),
307307
$this->_request->getRequestUri()
308308
);
309309
$this->_response->setBody($responseBody)->setHeader('Content-Type', 'application/json');

0 commit comments

Comments
 (0)