Skip to content

Commit a6079e1

Browse files
committed
ACP2E-3874: Order "base_row_total" and "row_total" show single item price in REST API response
1 parent 3678d2c commit a6079e1

File tree

1 file changed

+19
-91
lines changed

1 file changed

+19
-91
lines changed
Lines changed: 19 additions & 91 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,12 @@
11
<?php
22
/**
3-
* Copyright © Magento, Inc. All rights reserved.
4-
* See COPYING.txt for license details.
3+
* Copyright 2014 Adobe
4+
* All Rights Reserved.
55
*/
66
declare(strict_types=1);
77

88
namespace Magento\Sales\Test\Unit\Block\Adminhtml\Items\Column;
99

10-
use Magento\Framework\App\Config\ScopeConfigInterface;
1110
use Magento\Framework\TestFramework\Unit\Helper\ObjectManager as ObjectManagerHelper;
1211
use Magento\Sales\Block\Adminhtml\Items\Column\DefaultColumn;
1312
use Magento\Sales\Model\Order\Item;
@@ -29,114 +28,43 @@ class DefaultColumnTest extends TestCase
2928
*/
3029
protected $itemMock;
3130

32-
/**
33-
* @var ScopeConfigInterface|MockObject
34-
*/
35-
protected $scopeConfigMock;
36-
3731
protected function setUp(): void
3832
{
3933
$this->objectManagerHelper = new ObjectManagerHelper($this);
40-
$this->scopeConfigMock = $this->getMockBuilder(ScopeConfigInterface::class)
41-
->disableOriginalConstructor()
42-
->getMockForAbstractClass();
4334
$this->defaultColumn = $this->objectManagerHelper->getObject(
44-
DefaultColumn::class,
45-
[
46-
'scopeConfig' => $this->scopeConfigMock
47-
]
35+
DefaultColumn::class
4836
);
4937
$this->itemMock = $this->getMockBuilder(Item::class)
5038
->disableOriginalConstructor()
39+
->setMethods(['getRowTotal', 'getDiscountAmount', 'getBaseRowTotal', 'getBaseDiscountAmount'])
5140
->getMock();
5241
}
5342

54-
/**
55-
* Verify the total amount based on the price including tax flag
56-
*
57-
* @dataProvider getScopeConfigSalesPriceDataProvider
58-
* @param string $taxIncl
59-
* @param float|null $basePriceInclTax
60-
* @param float $basePrice
61-
* @param float $expectedResult
62-
* @return void
63-
* @throws \ReflectionException
64-
*/
65-
public function testGetTotalAmount(string $taxIncl, $priceInclTax, float $price, float $expectedResult): void
43+
public function testGetTotalAmount()
6644
{
67-
$storeId = 1;
68-
$discountAmount = 15.21;
69-
$taxAmount = 0.34;
45+
$rowTotal = 10;
46+
$discountAmount = 2;
47+
$expectedResult = 8;
7048
$this->itemMock->expects($this->once())
71-
->method('getStoreId')
72-
->willReturn($storeId);
73-
$this->itemMock->expects($this->any())
74-
->method('getPriceInclTax')
75-
->willReturn($priceInclTax);
76-
$this->itemMock->expects($this->any())
77-
->method('getPrice')
78-
->willReturn($price);
49+
->method('getRowTotal')
50+
->willReturn($rowTotal);
7951
$this->itemMock->expects($this->once())
8052
->method('getDiscountAmount')
8153
->willReturn($discountAmount);
82-
$this->itemMock->expects($this->any())
83-
->method('getTaxAmount')
84-
->willReturn($taxAmount);
85-
$this->scopeConfigMock->expects($this->atLeastOnce())
86-
->method('getValue')
87-
->willReturn($taxIncl);
88-
$this->assertEquals($expectedResult, round($this->defaultColumn->getTotalAmount($this->itemMock), 2));
54+
$this->assertEquals($expectedResult, $this->defaultColumn->getTotalAmount($this->itemMock));
8955
}
9056

91-
/**
92-
* Verify the total base amount based on the price including tax flag
93-
*
94-
* @dataProvider getScopeConfigSalesPriceDataProvider
95-
* @param string $taxIncl
96-
* @param float|null $basePriceInclTax
97-
* @param float $basePrice
98-
* @param float $expectedResult
99-
* @return void
100-
* @throws \ReflectionException
101-
*/
102-
public function testGetBaseTotalAmount(
103-
string $taxIncl,
104-
$basePriceInclTax,
105-
float $basePrice,
106-
float $expectedResult
107-
): void {
108-
$storeId = 1;
109-
$baseDiscountAmount = 15.21;
110-
$baseTaxAmount = 0.34;
57+
public function testGetBaseTotalAmount()
58+
{
59+
$baseRowTotal = 10;
60+
$baseDiscountAmount = 2;
61+
$expectedResult = 8;
11162
$this->itemMock->expects($this->once())
112-
->method('getStoreId')
113-
->willReturn($storeId);
114-
$this->itemMock->expects($this->any())
115-
->method('getBasePriceInclTax')
116-
->willReturn($basePriceInclTax);
117-
$this->itemMock->expects($this->any())
118-
->method('getBasePrice')
119-
->willReturn($basePrice);
63+
->method('getBaseRowTotal')
64+
->willReturn($baseRowTotal);
12065
$this->itemMock->expects($this->once())
12166
->method('getBaseDiscountAmount')
12267
->willReturn($baseDiscountAmount);
123-
$this->itemMock->expects($this->any())
124-
->method('getBaseTaxAmount')
125-
->willReturn($baseTaxAmount);
126-
$this->scopeConfigMock->expects($this->atLeastOnce())
127-
->method('getValue')
128-
->willReturn($taxIncl);
129-
$this->assertEquals($expectedResult, round($this->defaultColumn->getBaseTotalAmount($this->itemMock), 2));
130-
}
131-
132-
/**
133-
* @return array
134-
*/
135-
public static function getScopeConfigSalesPriceDataProvider(): array
136-
{
137-
return [
138-
['2', 16.9, 13.52, 1.35],
139-
['1', null, 16.9, 1.69],
140-
];
68+
$this->assertEquals($expectedResult, $this->defaultColumn->getBaseTotalAmount($this->itemMock));
14169
}
14270
}

0 commit comments

Comments
 (0)