MC-15406: [FT] [MFTF] StorefrontPurchaseProductCustomOptionsDifferentStoreViewsTest fails because of bad design

Author: zakdma

app/code/Magento/Store/Test/Mftf/ActionGroup/AdminCreateStoreViewActionGroup.xml

@@ -8,6 +8,7 @@
 <!-- Test XML Example -->
 <actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
               xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
+
     <actionGroup name="AdminCreateStoreViewActionGroup">
         <arguments>
             <argument name="StoreGroup" defaultValue="_defaultStoreGroup"/>
@@ -28,17 +29,12 @@
         <waitForElementVisible selector="{{AdminMessagesSection.success}}" stepKey="waitForPageReolad"/>
         <see selector="{{AdminMessagesSection.success}}" userInput="You saved the store view." stepKey="seeSavedMessage" />
     </actionGroup>
-    <!--Save the Store view-->
-    <actionGroup name="AdminCreateStoreViewActionSaveGroup">
-        <waitForLoadingMaskToDisappear stepKey="waitForGridLoad"/>
-        <waitForElementVisible selector="{{AdminStoresGridSection.websiteFilterTextField}}" stepKey="waitForStoreGridToReload2"/>
-        <see userInput="You saved the store view." stepKey="seeSavedMessage" />
-    </actionGroup>
-    <!--Save the same Store view code for code validation-->
-    <actionGroup name="AdminCreateStoreViewCodeUniquenessActionGroup">
-        <waitForLoadingMaskToDisappear stepKey="waitForForm"/>
-        <see userInput="Store with the same code already exists." stepKey="seeMessage" />
+
+    <actionGroup name="AdminCreateStoreViewWithoutCheckActionGroup" extends="AdminCreateStoreViewActionGroup">
+        <remove keyForRemoval="waitForPageReolad"/>
+        <remove keyForRemoval="seeSavedMessage"/>
     </actionGroup>
+
     <actionGroup name="navigateToAdminContentManagementPage">
         <amOnPage url="{{AdminContentManagementPage.url}}" stepKey="navigateToConfigurationPage"/>
         <waitForPageLoad stepKey="waitForPageLoad1"/>

app/code/Magento/Store/Test/Mftf/Section/AdminStoresGridSection.xml

@@ -23,5 +23,6 @@
         <element name="firstRow" type="textarea" selector="(//*[@id='storeGrid_table']/tbody/tr)[1]"/>
         <element name="successMessage" type="text" selector="//div[@class='message message-success success']/div"/>
         <element name="emptyText" type="text" selector="//tr[@class='data-grid-tr-no-data even']/td[@class='empty-text']"/>
+        <element name="gridCell" type="text" selector="//table[@class='data-grid']//tr[{{row}}]//td[count(//table[@class='data-grid']//tr//th[contains(., '{{column}}')]/preceding-sibling::th) +1 ]" parameterized="true"/>
      </section>
 </sections>

app/code/Magento/Store/Test/Mftf/Test/AdminCreateStoreViewTest.xml

@@ -11,32 +11,36 @@
             <annotations>
                 <features value="Store"/>
                 <stories value="Create a store view in admin"/>
-                <title value="Admin should be able to create a store view"/>
-                <description value="Admin should be able to create a store view"/>
+                <title value="Admin shouldn't be able to create a Store View with the same code"/>
+                <description value="Admin shouldn't be able to create a Store View with the same code"/>
                 <group value="storeView"/>
                 <severity value="AVERAGE"/>
-                <testCaseId value="MAGETWO-95111"/>
+                <useCaseId value="MAGETWO-95111"/>
+                <testCaseId value="MC-15422"/>
             </annotations>
+
             <before>
-                <actionGroup ref="LoginActionGroup" stepKey="login"/>
+                <actionGroup ref="LoginActionGroup" stepKey="loginAsAdmin"/>
                 <actionGroup ref="AdminCreateStoreViewActionGroup" stepKey="createStoreView" />
-                <!--<createData stepKey="b2" entity="customStoreGroup"/>-->
             </before>
-            <!--Save store view on Store Grid-->
-            <actionGroup ref="AdminCreateStoreViewActionSaveGroup" stepKey="createStoreViewSave" />
-            <!--Confirm new store view created on Store Grid-->
-            <fillField selector="{{AdminStoresGridSection.storeFilterTextField}}" userInput="{{customStore.name}}" stepKey="fillStoreViewFilter"/>
-            <click selector="{{AdminStoresGridSection.searchButton}}" stepKey="clickSearch" />
-            <waitForPageLoad stepKey="waitForPageLoad"/>
-            <see selector="{{AdminStoresGridSection.storeNameInFirstRow}}" userInput="{{customStore.name}}" stepKey="seeNewStoreView" />
-            <!--Creating the same store view to validate the code uniqueness on store form-->
-            <actionGroup ref="AdminCreateStoreViewActionGroup" stepKey="createStoreView2" />
-            <actionGroup ref="AdminCreateStoreViewCodeUniquenessActionGroup" stepKey="createStoreViewCode" />
+
             <after>
                 <actionGroup ref="AdminDeleteStoreViewActionGroup" stepKey="deleteStoreView">
                     <argument name="customStore" value="customStore"/>
                 </actionGroup>
+                <click selector="{{AdminStoresGridSection.resetButton}}" stepKey="resetSearchFilter"/>
                 <actionGroup ref="logout" stepKey="logout"/>
             </after>
+
+            <!--Filter grid and see created store view-->
+            <amOnPage url="{{AdminSystemStorePage.url}}" stepKey="navigateToStoresIndex"/>
+            <click selector="{{AdminStoresGridSection.resetButton}}" stepKey="resetSearchFilter"/>
+            <fillField selector="{{AdminStoresGridSection.storeFilterTextField}}" userInput="{{customStore.name}}" stepKey="fillStoreViewFilterField"/>
+            <click selector="{{AdminStoresGridSection.searchButton}}" stepKey="clickSearch"/>
+            <see selector="{{AdminStoresGridSection.gridCell('1', 'Store View')}}" userInput="{{customStore.name}}" stepKey="seeNewStoreView"/>
+            <!--Try to create store view with the same code-->
+            <actionGroup ref="AdminCreateStoreViewWithoutCheckActionGroup" stepKey="createSameStoreView"/>
+            <dontSeeElement selector="{{AdminMessagesSection.success}}" stepKey="dontSeeSuccessMessage"/>
+            <see selector="{{AdminMessagesSection.error}}" userInput="Store with the same code already exists." stepKey="seeErrorMessage"/>
         </test>
 </tests>