Skip to content

Commit a599bf3

Browse files
author
Olexandr Lysenko
committed
MAGETWO-31593: Sales Quote as Standalone Magento Module
1 parent 4178109 commit a599bf3

File tree

6 files changed

+3
-22
lines changed

6 files changed

+3
-22
lines changed

app/code/Magento/Quote/Model/QuoteManagement.php

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -111,12 +111,6 @@ public function submit(QuoteEntity $quote, $orderData = [])
111111
$quote->setIsActive(false);
112112
return;
113113
}
114-
$this->eventManager->dispatch(
115-
'sales_model_service_quote_submit_nominal_items',
116-
[
117-
'quote' => $quote
118-
]
119-
);
120114

121115
return $this->submitQuote($quote, $orderData);
122116
}

app/code/Magento/Quote/etc/fieldset.xml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -257,9 +257,6 @@
257257
<field name="base_hidden_tax_amount">
258258
<aspect name="to_order_item" />
259259
</field>
260-
<field name="is_nominal">
261-
<aspect name="to_order_item" />
262-
</field>
263260
<field name="product_id">
264261
<aspect name="to_order_item" />
265262
</field>

app/code/Magento/Quote/etc/sales.xml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,14 +8,9 @@
88
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="../../Sales/etc/sales.xsd">
99
<section name="quote">
1010
<group name="totals">
11-
<item name="nominal" instance="Magento\Quote\Model\Quote\Address\Total\Nominal" sort_order="50"/>
1211
<item name="subtotal" instance="Magento\Quote\Model\Quote\Address\Total\Subtotal" sort_order="100"/>
1312
<item name="shipping" instance="Magento\Quote\Model\Quote\Address\Total\Shipping" sort_order="250"/>
1413
<item name="grand_total" instance="Magento\Quote\Model\Quote\Address\Total\Grand" sort_order="550"/>
1514
</group>
16-
<group name="nominal_totals">
17-
<item name="nominal_subtotal" instance="Magento\Quote\Model\Quote\Address\Total\Nominal\Subtotal" sort_order="250"/>
18-
<item name="nominal_shipping" instance="Magento\Quote\Model\Quote\Address\Total\Nominal\Shipping" sort_order="1250"/>
19-
</group>
2015
</section>
2116
</config>

composer.lock

Lines changed: 1 addition & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dev/tests/static/testsuite/Magento/Test/Legacy/_files/obsolete_methods.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2026,6 +2026,6 @@
20262026
['getAllNonNominalItems', 'Magento\Sales\Model\Quote\Address'],
20272027
['getAllNominalItems', 'Magento\Sales\Model\Quote\Address'],
20282028
['isNominal', 'Magento\Sales\Model\Order\Item'],
2029-
['getIsNominal', 'Magento\Sales\Model\Quote\Item\AbbstractItem']
2029+
['getIsNominal', 'Magento\Sales\Model\Quote\Item\AbbstractItem'],
20302030
['checkQuoteAmount', 'Magento\Sales\Helper\Data']
20312031
];

dev/tests/unit/testsuite/Magento/Quote/Model/QuoteManagementTest.php

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -202,17 +202,13 @@ public function testSubmit()
202202
->willReturn($order);
203203

204204
$this->eventManager->expects($this->at(0))
205-
->method('dispatch')
206-
->with('sales_model_service_quote_submit_nominal_items', ['quote' => $quote]);
207-
$this->eventManager->expects($this->at(1))
208205
->method('dispatch')
209206
->with('sales_model_service_quote_submit_before', ['order' => $order, 'quote' => $quote]);
210-
$this->eventManager->expects($this->at(2))
207+
$this->eventManager->expects($this->at(1))
211208
->method('dispatch')
212209
->with('sales_model_service_quote_submit_success', ['order' => $order, 'quote' => $quote]);
213210

214211
$this->assertEquals($order, $this->model->submit($quote, $orderData));
215-
216212
}
217213

218214
protected function getQuote(

0 commit comments

Comments
 (0)