Skip to content

Commit a58d708

Browse files
committed
Code review changes
1 parent f30f777 commit a58d708

File tree

4 files changed

+658
-659
lines changed

4 files changed

+658
-659
lines changed

app/code/Magento/Paypal/Model/Config.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -831,7 +831,7 @@ public function getCountryMethods($countryCode = null)
831831
* @param string $token
832832
* @return string
833833
*/
834-
public function getPayPalBasicStartUrl($token)
834+
public function getPayPalBasicStartUrl($token): string
835835
{
836836
$params = [
837837
'cmd' => '_express-checkout',

app/code/Magento/Paypal/Model/SdkUrl.php

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -177,9 +177,7 @@ private function getClientId()
177177
*/
178178
private function getBuyerCountry(): string
179179
{
180-
return (int)$this->config->getValue('sandbox_flag') ?
181-
$this->config->getValue('buyer_country') :
182-
'';
180+
return (int)$this->config->getValue('sandbox_flag') ? $this->config->getValue('buyer_country') : '';
183181
}
184182

185183
/**

app/code/Magento/Paypal/Test/Unit/Model/_files/expected_url_config.php

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ function generateExpectedPaypalSdkUrl(array $params) : String
4747
'sofort'
4848
]
4949
),
50-
'components' => implode(',', ['messages', 'buttons'])
50+
'components' => implode(',', ['messages', 'buttons']),
5151
]
5252
)
5353
]
@@ -71,7 +71,7 @@ function generateExpectedPaypalSdkUrl(array $params) : String
7171
',',
7272
['venmo', 'bancontact', 'eps', 'giropay', 'ideal', 'mybank', 'p24', 'sofort']
7373
),
74-
'components' => implode(',', ['messages', 'buttons'])
74+
'components' => implode(',', ['messages', 'buttons']),
7575
]
7676
)
7777
]
@@ -95,7 +95,7 @@ function generateExpectedPaypalSdkUrl(array $params) : String
9595
',',
9696
['venmo', 'bancontact', 'eps', 'giropay', 'ideal', 'mybank', 'p24', 'sofort']
9797
),
98-
'components' => implode(',', ['messages', 'buttons'])
98+
'components' => implode(',', ['messages', 'buttons']),
9999
]
100100
)
101101
]
@@ -131,7 +131,7 @@ function generateExpectedPaypalSdkUrl(array $params) : String
131131
'sofort'
132132
]
133133
),
134-
'components' => implode(',', ['messages', 'buttons'])
134+
'components' => implode(',', ['messages', 'buttons']),
135135
]
136136
)
137137
]
@@ -155,7 +155,7 @@ function generateExpectedPaypalSdkUrl(array $params) : String
155155
',',
156156
['credit', 'sepa', 'venmo', 'bancontact', 'eps', 'giropay', 'ideal', 'mybank', 'p24', 'sofort']
157157
),
158-
'components' => implode(',', ['messages', 'buttons'])
158+
'components' => implode(',', ['messages', 'buttons']),
159159
]
160160
)
161161
]
@@ -204,7 +204,7 @@ function generateExpectedPaypalSdkUrl(array $params) : String
204204
',',
205205
['credit', 'sepa', 'venmo', 'bancontact', 'eps', 'giropay', 'ideal', 'mybank', 'p24', 'sofort']
206206
),
207-
'components' => implode(',', ['messages', 'buttons'])
207+
'components' => implode(',', ['messages', 'buttons']),
208208
]
209209
)
210210
]

0 commit comments

Comments
 (0)