MAGETWO-36792: Remove Magento\ConfigurableProduct\Api\OptionTypesListInterface and type field in OptionInterface

Author: Yu Tang

app/code/Magento/ConfigurableProduct/Api/Data/OptionInterface.php

@@ -41,17 +41,6 @@ public function getLabel();
      */
     public function setLabel($label);
 
-    /**
-     * @return string|null
-     */
-    public function getType();
-
-    /**
-     * @param string $type
-     * @return $this
-     */
-    public function setType($type);
-
     /**
      * @return int|null
      */

app/code/Magento/ConfigurableProduct/Api/OptionTypesListInterface.php

@@ -253,9 +253,6 @@ public function validateNewOptionData(\Magento\ConfigurableProduct\Api\Data\Opti
         if (!$option->getAttributeId()) {
             $inputException->addError(__('Option attribute ID is not specified.'));
         }
-        if (!$option->getType()) {
-            $inputException->addError(__('Option type is not specified.'));
-        }
         if (!$option->getLabel()) {
             $inputException->addError(__('Option label is not specified.'));
         }

app/code/Magento/ConfigurableProduct/Model/OptionRepository.php

@@ -24,7 +24,6 @@ class Attribute extends \Magento\Framework\Model\AbstractExtensibleModel impleme
      */
     const KEY_ATTRIBUTE_ID = 'attribute_id';
     const KEY_LABEL = 'label';
-    const KEY_TYPE = 'type';
     const KEY_POSITION = 'position';
     const KEY_IS_USE_DEFAULT = 'is_use_default';
     const KEY_VALUES = 'values';
@@ -119,15 +118,6 @@ public function getAttributeId()
         return $this->getData(self::KEY_ATTRIBUTE_ID);
     }
 
-    /**
-     * {@inheritdoc}
-     * @codeCoverageIgnore
-     */
-    public function getType()
-    {
-        return $this->getData(self::KEY_TYPE);
-    }
-
     /**
      * {@inheritdoc}
      * @codeCoverageIgnore
@@ -174,15 +164,6 @@ public function setLabel($label)
         return $this->setData(self::KEY_LABEL, $label);
     }
 
-    /**
-     * @param string $type
-     * @return $this
-     */
-    public function setType($type)
-    {
-        return $this->setData(self::KEY_TYPE, $type);
-    }
-
     /**
      * @param int $position
      * @return $this

app/code/Magento/ConfigurableProduct/Model/OptionTypesList.php

@@ -6,7 +6,6 @@
  */
 -->
 <config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="../../../../../lib/internal/Magento/Framework/ObjectManager/etc/config.xsd">
-    <preference for="Magento\ConfigurableProduct\Api\OptionTypesListInterface" type="Magento\ConfigurableProduct\Model\OptionTypesList" />
     <preference for="Magento\ConfigurableProduct\Api\ConfigurableProductManagementInterface" type="Magento\ConfigurableProduct\Model\ConfigurableProductManagement" />
     <preference for="Magento\ConfigurableProduct\Api\LinkManagementInterface" type="Magento\ConfigurableProduct\Model\LinkManagement" />
     <preference for="Magento\ConfigurableProduct\Api\OptionRepositoryInterface" type="Magento\ConfigurableProduct\Model\OptionRepository" />

app/code/Magento/ConfigurableProduct/Model/Product/Type/Configurable/Attribute.php

@@ -43,12 +43,6 @@
             <resource ref="Magento_Catalog::products"/>
         </resources>
     </route>
-    <route url="/V1/configurable-products/options/types" method="GET">
-        <service class="Magento\ConfigurableProduct\Api\OptionTypesListInterface" method="getItems" />
-        <resources>
-            <resource ref="Magento_Catalog::products" />
-        </resources>
-    </route>
     <route url="/V1/configurable-products/:sku/options" method="POST">
         <service class="Magento\ConfigurableProduct\Api\OptionRepositoryInterface" method="save" />
         <resources>

app/code/Magento/ConfigurableProduct/Test/Unit/Model/OptionTypesListTest.php

@@ -166,7 +166,6 @@ public function testAdd()
         ];
         $option = [
             'attribute_id' => 'test_configurable',
-            'type' => 'select',
             'label' => 'Test',
             'values' => [
                 [