Skip to content

Commit a57ae0d

Browse files
committed
Merge branch 'MC-42883' of https://github.com/magento-l3/magento2ce into L3-PR-20210908
2 parents 67974e8 + dafd7f2 commit a57ae0d

File tree

2 files changed

+2
-25
lines changed

2 files changed

+2
-25
lines changed

app/code/Magento/Customer/Controller/Account/Logout.php

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88

99
namespace Magento\Customer\Controller\Account;
1010

11-
use Magento\Customer\Api\SessionCleanerInterface;
1211
use Magento\Framework\App\Action\HttpPostActionInterface;
1312
use Magento\Framework\App\Action\HttpGetActionInterface;
1413
use Magento\Customer\Model\Session;
@@ -38,24 +37,15 @@ class Logout extends AbstractAccount implements HttpGetActionInterface, HttpPost
3837
*/
3938
private $cookieMetadataManager;
4039

41-
/**
42-
* @var SessionCleanerInterface
43-
*/
44-
private $sessionCleaner;
45-
4640
/**
4741
* @param Context $context
4842
* @param Session $customerSession
49-
* @param SessionCleanerInterface|null $sessionCleaner
5043
*/
5144
public function __construct(
5245
Context $context,
53-
Session $customerSession,
54-
SessionCleanerInterface $sessionCleaner = null
46+
Session $customerSession
5547
) {
5648
$this->session = $customerSession;
57-
$objectManager = ObjectManager::getInstance();
58-
$this->sessionCleaner = $sessionCleaner ?? $objectManager->get(SessionCleanerInterface::class);
5949
parent::__construct($context);
6050
}
6151

@@ -97,7 +87,6 @@ public function execute()
9787
$lastCustomerId = $this->session->getId();
9888
$this->session->logout()->setBeforeAuthUrl($this->_redirect->getRefererUrl())
9989
->setLastCustomerId($lastCustomerId);
100-
$this->sessionCleaner->clearFor((int)$lastCustomerId);
10190
if ($this->getCookieManager()->getCookie('mage-cache-sessid')) {
10291
$metadata = $this->getCookieMetadataFactory()->createCookieMetadata();
10392
$metadata->setPath('/');

app/code/Magento/Customer/Test/Unit/Controller/Account/LogoutTest.php

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77

88
namespace Magento\Customer\Test\Unit\Controller\Account;
99

10-
use Magento\Customer\Api\SessionCleanerInterface;
1110
use Magento\Customer\Controller\Account\Logout;
1211
use Magento\Customer\Model\Session;
1312
use Magento\Framework\App\Action\Context;
@@ -49,11 +48,6 @@ class LogoutTest extends TestCase
4948
/** @var RedirectInterface|MockObject */
5049
protected $redirect;
5150

52-
/**
53-
* @var SessionCleanerInterface|MockObject
54-
*/
55-
private $sessionCleanerMock;
56-
5751
protected function setUp(): void
5852
{
5953
$this->contextMock = $this->getMockBuilder(Context::class)
@@ -63,7 +57,6 @@ protected function setUp(): void
6357
->disableOriginalConstructor()
6458
->setMethods(['getId', 'logout', 'setBeforeAuthUrl', 'setLastCustomerId'])
6559
->getMock();
66-
$this->sessionCleanerMock = $this->createMock(SessionCleanerInterface::class);
6760

6861
$this->cookieMetadataFactory = $this->getMockBuilder(CookieMetadataFactory::class)
6962
->disableOriginalConstructor()
@@ -90,7 +83,7 @@ protected function setUp(): void
9083
->method('getRedirect')
9184
->willReturn($this->redirect);
9285

93-
$this->controller = new Logout($this->contextMock, $this->sessionMock, $this->sessionCleanerMock);
86+
$this->controller = new Logout($this->contextMock, $this->sessionMock);
9487

9588
$refClass = new \ReflectionClass(Logout::class);
9689
$cookieMetadataManagerProperty = $refClass->getProperty('cookieMetadataManager');
@@ -124,11 +117,6 @@ public function testExecute()
124117
->method('setLastCustomerId')
125118
->with($customerId);
126119

127-
$this->sessionCleanerMock->expects($this->once())
128-
->method('clearFor')
129-
->with($customerId)
130-
->willReturnSelf();
131-
132120
$this->cookieManager->expects($this->once())
133121
->method('getCookie')
134122
->with('mage-cache-sessid')

0 commit comments

Comments
 (0)