MAGETWO-95215: [GraphQL] Performance issue in filters realization

- Fixed code style violations

Author: paliarush

app/code/Magento/Catalog/Model/Product/Media/Config.php

@@ -10,11 +10,9 @@
 use Magento\Store\Model\StoreManagerInterface;
 
 /**
- * Catalog product media config
+ * Catalog product media config.
  *
  * @api
- *
- * @author      Magento Core Team <core@magentocommerce.com>
  * @since 100.0.2
  */
 class Config implements ConfigInterface
@@ -45,8 +43,7 @@ public function __construct(StoreManagerInterface $storeManager)
     }
 
     /**
-     * Filesystem directory path of product images
-     * relatively to media folder
+     * Get filesystem directory path for product images relative to the media directory.
      *
      * @return string
      */
@@ -56,8 +53,7 @@ public function getBaseMediaPathAddition()
     }
 
     /**
-     * Web-based directory path of product images
-     * relatively to media folder
+     * Get web-based directory path for product images relative to the media directory.
      *
      * @return string
      */
@@ -67,15 +63,15 @@ public function getBaseMediaUrlAddition()
     }
 
     /**
-     * @return string
+     * @inheritdoc
      */
     public function getBaseMediaPath()
     {
         return 'catalog/product';
     }
 
     /**
-     * @return string
+     * @inheritdoc
      */
     public function getBaseMediaUrl()
     {
@@ -84,8 +80,7 @@ public function getBaseMediaUrl()
     }
 
     /**
-     * Filesystem directory path of temporary product images
-     * relatively to media folder
+     * Filesystem directory path of temporary product images relative to the media directory.
      *
      * @return string
      */
@@ -95,6 +90,8 @@ public function getBaseTmpMediaPath()
     }
 
     /**
+     * Get temporary base media URL.
+     *
      * @return string
      */
     public function getBaseTmpMediaUrl()
@@ -105,24 +102,24 @@ public function getBaseTmpMediaUrl()
     }
 
     /**
-     * @param string $file
-     * @return string
+     * @inheritdoc
      */
     public function getMediaUrl($file)
     {
         return $this->getBaseMediaUrl() . '/' . $this->_prepareFile($file);
     }
 
     /**
-     * @param string $file
-     * @return string
+     * @inheritdoc
      */
     public function getMediaPath($file)
     {
         return $this->getBaseMediaPath() . '/' . $this->_prepareFile($file);
     }
 
     /**
+     * Get temporary media URL.
+     *
      * @param string $file
      * @return string
      */
@@ -132,8 +129,7 @@ public function getTmpMediaUrl($file)
     }
 
     /**
-     * Part of URL of temporary product images
-     * relatively to media folder
+     * Part of URL of temporary product images relative to the media directory.
      *
      * @param string $file
      * @return string
@@ -144,7 +140,7 @@ public function getTmpMediaShortUrl($file)
     }
 
     /**
-     * Part of URL of product images relatively to media folder
+     * Part of URL of product images relatively to media folder.
      *
      * @param string $file
      * @return string
@@ -155,6 +151,8 @@ public function getMediaShortUrl($file)
     }
 
     /**
+     * Get path to the temporary media.
+     *
      * @param string $file
      * @return string
      */
@@ -164,6 +162,8 @@ public function getTmpMediaPath($file)
     }
 
     /**
+     * Process file path.
+     *
      * @param string $file
      * @return string
      */
@@ -173,18 +173,23 @@ protected function _prepareFile($file)
     }
 
     /**
+     * Get codes of media attribute.
+     *
      * @return array
      * @since 100.0.4
      */
     public function getMediaAttributeCodes()
     {
         if (!isset($this->mediaAttributeCodes)) {
+            // the in-memory object-level caching allows to prevent unnecessary calls to the DB
             $this->mediaAttributeCodes = $this->getAttributeHelper()->getAttributeCodesByFrontendType('media_image');
         }
         return $this->mediaAttributeCodes;
     }
 
     /**
+     * Get attribute helper.
+     *
      * @return Attribute
      */
     private function getAttributeHelper()

app/code/Magento/CatalogGraphQl/Model/Resolver/Categories.php

@@ -78,7 +78,8 @@ public function __construct(
     }
 
     /**
-     * {@inheritdoc}
+     * @inheritdoc
+     *
      * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
     public function resolve(Field $field, $context, ResolveInfo $info, array $value = null, array $args = null)
@@ -106,7 +107,6 @@ public function resolve(Field $field, $context, ResolveInfo $info, array $value
             /** @var CategoryInterface | \Magento\Catalog\Model\Category $item */
             foreach ($this->collection as $item) {
                 if (in_array($item->getId(), $categoryIds)) {
-
                     // Try to extract all requested fields from the loaded collection data
                     $categories[$item->getId()] = $this->categoryHydrator->hydrateCategory($item, true);
                     $requestedFields = $that->attributesJoiner->getQueryFields($info->fieldNodes[0]);
@@ -118,7 +118,6 @@ public function resolve(Field $field, $context, ResolveInfo $info, array $value
 
                     // If not all requested fields were extracted from the collection, start more complex extraction
                     $categories[$item->getId()] = $this->categoryHydrator->hydrateCategory($item);
-
                 }
             }
 

lib/internal/Magento/Framework/GraphQl/Config.php

@@ -53,6 +53,7 @@ public function __construct(
      * @param string $configElementName
      * @return ConfigElementInterface
      * @throws \LogicException
+     * @SuppressWarnings(PHPMD.UnusedLocalVariable)
      */
     public function getConfigElement(string $configElementName) : ConfigElementInterface
     {
@@ -65,11 +66,11 @@ public function getConfigElement(string $configElementName) : ConfigElementInter
 
         $fieldsInQuery = $this->queryFields->getFieldsUsedInQuery();
         if (isset($data['fields']) && !empty($fieldsInQuery)) {
-           foreach ($data['fields'] as $fieldName => $fieldConfig) {
-               if (!isset($fieldsInQuery[$fieldName])) {
-                   unset($data['fields'][$fieldName]);
-               }
-           }
+            foreach ($data['fields'] as $fieldName => $fieldConfig) {
+                if (!isset($fieldsInQuery[$fieldName])) {
+                    unset($data['fields'][$fieldName]);
+                }
+            }
         }
 
         return $this->configElementFactory->createFromConfigData($data);