Skip to content

Commit a4cae96

Browse files
committed
MAGETWO-69121: Loader doesn't disappear if Authorize.net transact.dll fails request
- Added stop loader for unsuccessful place order flow
1 parent 1aaa2fc commit a4cae96

File tree

3 files changed

+37
-3
lines changed

3 files changed

+37
-3
lines changed

app/code/Magento/Payment/view/frontend/templates/transparent/iframe.phtml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
*/
66

77
// @codingStandardsIgnoreFile
8-
use Magento\Framework\Json\Helper\Data;
98

109
/** @var \Magento\Payment\Block\Transparent\Iframe $block */
1110
$params = $block->getParams();
@@ -33,11 +32,13 @@ $params = $block->getParams();
3332
[
3433
'jquery',
3534
'Magento_Ui/js/model/messageList',
36-
'mage/translate'
35+
'mage/translate',
36+
'Magento_Checkout/js/model/full-screen-loader'
3737
],
38-
function($, globalMessageList, $t) {
38+
function($, globalMessageList, $t, fullScreenLoader) {
3939
var parent = window.top;
4040
$(parent).trigger('clearTimeout');
41+
fullScreenLoader.stopLoader();
4142
globalMessageList.addErrorMessage({
4243
message: $t('An error occurred on the server. Please try to place the order again.')
4344
});

dev/tests/functional/tests/app/Magento/Authorizenet/Test/Repository/ConfigData.xml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -151,5 +151,13 @@
151151
<item name="value" xsi:type="string">authorize</item>
152152
</field>
153153
</dataset>
154+
<dataset name="authorizenet_wrong_credentials">
155+
<field name="payment/authorizenet_directpost/trans_md5" xsi:type="array">
156+
<item name="scope" xsi:type="string">payment</item>
157+
<item name="scope_id" xsi:type="number">1</item>
158+
<item name="label" xsi:type="string"/>
159+
<item name="value" xsi:type="string"></item>
160+
</field>
161+
</dataset>
154162
</repository>
155163
</config>
Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,25 @@
1+
<?xml version="1.0" encoding="utf-8"?>
2+
<!--
3+
/**
4+
* Copyright © Magento, Inc. All rights reserved.
5+
* See COPYING.txt for license details.
6+
*/
7+
-->
8+
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="../../../../../../vendor/magento/mtf/etc/variations.xsd">
9+
<testCase name="Magento\Checkout\Test\TestCase\OnePageCheckoutDeclinedTest" summary="Error message during OnePageCheckout">
10+
<variation name="OnePageCheckoutAuthorizenetWrongCredentials" summary="Error during place order flow with Authorize.net" ticketId="MAGETWO-69995">
11+
<data name="products/0" xsi:type="string">catalogProductSimple::product_10_dollar</data>
12+
<data name="customer/dataset" xsi:type="string">default</data>
13+
<data name="shippingAddress/dataset" xsi:type="string">US_address_1_without_email</data>
14+
<data name="checkoutMethod" xsi:type="string">login</data>
15+
<data name="shipping/shipping_service" xsi:type="string">Flat Rate</data>
16+
<data name="shipping/shipping_method" xsi:type="string">Fixed</data>
17+
<data name="payment/method" xsi:type="string">authorizenet_directpost</data>
18+
<data name="creditCard/dataset" xsi:type="string">visa_default</data>
19+
<data name="configData" xsi:type="string">authorizenet, authorizenet_wrong_credentials</data>
20+
<data name="expectedErrorMessage" xsi:type="string">An error occurred on the server. Please try to place the order again.</data>
21+
<data name="tag" xsi:type="string">test_type:3rd_party_test, severity:S2</data>
22+
<constraint name="Magento\Checkout\Test\Constraint\AssertCheckoutErrorMessage" />
23+
</variation>
24+
</testCase>
25+
</config>

0 commit comments

Comments
 (0)