Merge pull request #1218 from magento-engcom/develop-prs

Public Pull Requests

#9197

Author: Oleksii Korshenko

app/code/Magento/Sales/Controller/Adminhtml/Order/AbstractMassAction.php

@@ -14,6 +14,8 @@
 
 /**
  * Class AbstractMassStatus
+ * @deprecated
+ * Never extend from this action. Implement mass-action logic in the "execute" method of your controller.
  */
 abstract class AbstractMassAction extends \Magento\Backend\App\Action
 {
@@ -62,8 +64,8 @@ public function execute()
     }
 
     /**
-     * Return component referer url
-     * TODO: Technical dept referer url should be implement as a part of Action configuration in in appropriate way
+     * Return component referrer url
+     * TODO: Technical dept referrer url should be implement as a part of Action configuration in in appropriate way
      *
      * @return null|string
      */

lib/internal/Magento/Framework/Model/AbstractModel.php

@@ -524,7 +524,9 @@ public function getCollection()
      * @param integer $modelId
      * @param null|string $field
      * @return $this
-     * @deprecated
+     * @deprecated because entities must not be responsible for their own loading.
+     * Service contracts should persist entities. Use resource model "load" or collections to implement
+     * service contract model loading operations.
      */
     public function load($modelId, $field = null)
     {
@@ -631,7 +633,10 @@ public function setHasDataChanges($flag)
      *
      * @return $this
      * @throws \Exception
-     * @deprecated
+     *
+     * @deprecated because entities must not be responsible for their own persistence.
+     * Service contracts should persist entities. Use resource model "save" to implement
+     * service contract persistence operations.
      */
     public function save()
     {
@@ -816,7 +821,9 @@ public function afterSave()
      *
      * @return $this
      * @throws \Exception
-     * @deprecated
+     * @deprecated because entities must not be responsible for their own deletion.
+     * Service contracts should delete entities. Use resource model "delete" method to implement
+     * service contract persistence operations.
      */
     public function delete()
     {