MC-15439: Deferred loading / parsing of JS

vzabaznov · vzabaznov · commit a448ee502f8e · 2019-04-02T10:13:42.000-05:00
diff --git a/app/code/Magento/Theme/Controller/Result/JsFooterPlugin.php b/app/code/Magento/Theme/Controller/Result/JsFooterPlugin.php
@@ -20,8 +20,7 @@ public function beforeSendResponse(\Magento\Framework\App\Response\Http $subject
     {
         $content = $subject->getContent();
         $script = [];
-        if (strpos($content, '</body') > 0) {
-            $content = preg_replace('#<!--(?!\s?/?ko).*?-->#s', '', $content);
+        if (strpos($content, '</body') !== false) {
             $pattern = '#<script[^>]*+(?<!text/x-magento-template.)>.*?</script>#is';
             $content = preg_replace_callback(
                 $pattern,
@@ -36,4 +35,4 @@ function ($matchPart) use (&$script) {
             );
         }
     }
-}
+}

Original file line number	Diff line number	Diff line change
`@@ -20,8 +20,7 @@ public function beforeSendResponse(\Magento\Framework\App\Response\Http $subject`
`20`	`20`	`{`
`21`	`21`	`$content = $subject->getContent();`
`22`	`22`	`$script = [];`
`23`		`- if (strpos($content, '</body') > 0) {`
`24`		`- $content = preg_replace('#<!--(?!\s?/?ko).*?-->#s', '', $content);`
	`23`	`+ if (strpos($content, '</body') !== false) {`
`25`	`24`	`$pattern = '#<script[^>]+(?<!text/x-magento-template.)>.?</script>#is';`
`26`	`25`	`$content = preg_replace_callback(`
`27`	`26`	`$pattern,`
`@@ -36,4 +35,4 @@ function ($matchPart) use (&$script) {`
`36`	`35`	`);`
`37`	`36`	`}`
`38`	`37`	`}`
`39`		`-}`
	`38`	`+}`