ACP2E-3377: Cart rules "Fixed amount discount for whole cart" action applies discounts incorrectly when adding bundle products

aplapana · aplapana · commit a42efee6b6c7 · 2024-10-08T09:50:44.000+03:00
diff --git a/app/code/Magento/SalesRule/Model/Quote/Discount.php b/app/code/Magento/SalesRule/Model/Quote/Discount.php
@@ -222,9 +222,11 @@ public function collect(
                 }
 
                 if ($item->getChildren() && $item->isChildrenCalculated()) {
+                    $childTotal = 0;
                     foreach ($item->getChildren() as $child) {
-                        $totalDiscount[$item->getId()] += $child->getBaseDiscountAmount();
+                        $childTotal += $child->getBaseDiscountAmount();
                     }
+                    $totalDiscount[$item->getId()] = $childTotal;
                 } else {
                     $totalDiscount[$item->getId()] = $item->getBaseDiscountAmount();
                 }

Original file line number	Diff line number	Diff line change
`@@ -222,9 +222,11 @@ public function collect(`
`222`	`222`	`}`
`223`	`223`
`224`	`224`	`if ($item->getChildren() && $item->isChildrenCalculated()) {`
	`225`	`+ $childTotal = 0;`
`225`	`226`	`foreach ($item->getChildren() as $child) {`
`226`		`- $totalDiscount[$item->getId()] += $child->getBaseDiscountAmount();`
	`227`	`+ $childTotal += $child->getBaseDiscountAmount();`
`227`	`228`	`}`
	`229`	`+ $totalDiscount[$item->getId()] = $childTotal;`
`228`	`230`	`} else {`
`229`	`231`	`$totalDiscount[$item->getId()] = $item->getBaseDiscountAmount();`
`230`	`232`	`}`