MAGETWO-43717: Attribute Group Code Generation Algorithm is Incorrect

Author: Alex Akimov

app/code/Magento/Eav/Model/Entity/Attribute/Group.php

@@ -66,7 +66,8 @@ public function beforeSave()
         if (!$this->getAttributeGroupCode()) {
             $groupName = $this->getAttributeGroupName();
             if ($groupName) {
-                $this->setAttributeGroupCode(trim(preg_replace('/[^a-z0-9]+/', '-', strtolower($groupName)), '-'));
+                // in the following code md5 is not used for security purposes
+                $this->setAttributeGroupCode(md5($groupName));
             }
         }
         return parent::beforeSave();

app/code/Magento/Eav/Test/Unit/Model/Entity/Attribute/GroupTest.php

@@ -0,0 +1,50 @@
+<?php
+/**
+ * Copyright © 2015 Magento. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+namespace Magento\Eav\Test\Unit\Model\Entity\Attribute;
+
+use Magento\Eav\Model\Entity\Attribute\Group;
+use Magento\Framework\TestFramework\Unit\Helper\ObjectManager;
+
+class GroupTest extends \PHPUnit_Framework_TestCase
+{
+    /**
+     * @var Group
+     */
+    private $model;
+
+    /**
+     * @var \PHPUnit_Framework_MockObject_MockObject
+     */
+    private $resourceMock;
+
+    /**
+     * @var \PHPUnit_Framework_MockObject_MockObject
+     */
+    private $eventManagerMock;
+
+    protected function setUp()
+    {
+        $this->resourceMock = $this->getMock('Magento\Eav\Model\Resource\Entity\Attribute\Group', [], [], '', false);
+        $this->eventManagerMock = $this->getMock('Magento\Framework\Event\ManagerInterface');
+        $contextMock = $this->getMock('Magento\Framework\Model\Context', [], [], '', false);
+        $contextMock->expects($this->any())->method('getEventDispatcher')->willReturn($this->eventManagerMock);
+        $constructorArguments = [
+            'resource' => $this->resourceMock,
+            'context' => $contextMock,
+        ];
+        $objectManager = new ObjectManager($this);
+        $this->model = $objectManager->getObject('Magento\Eav\Model\Entity\Attribute\Group', $constructorArguments);
+    }
+
+    public function testBeforeSaveGeneratesGroupCodeBasedOnGroupName()
+    {
+        $groupName = 'General';
+        $expectedGroupCode = md5($groupName);
+        $this->model->setAttributeGroupName($groupName);
+        $this->model->beforeSave();
+        $this->assertEquals($expectedGroupCode, $this->model->getAttributeGroupCode());
+    }
+}