Skip to content

Commit a369241

Browse files
committed
ACP2E-2129: customer is reporting their table rates are not updating via CSV any longer
- addressed static report
1 parent ec7d56d commit a369241

File tree

1 file changed

+2
-4
lines changed
  • app/code/Magento/OfflineShipping/Model/ResourceModel/Carrier

1 file changed

+2
-4
lines changed

app/code/Magento/OfflineShipping/Model/ResourceModel/Carrier/Tablerate.php

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -185,7 +185,7 @@ public function __construct(
185185
\Magento\Framework\Filesystem $filesystem,
186186
Import $import,
187187
RateQueryFactory $rateQueryFactory,
188-
?string $connectionName = null,
188+
$connectionName = null,
189189
?DeploymentConfig $deploymentConfig = null,
190190
?RequestFactory $requestFactory = null,
191191
?IoFile $ioFile = null
@@ -296,7 +296,7 @@ private function importData(array $fields, array $values)
296296
* @todo: this method should be refactored as soon as updated design will be provided
297297
* @see https://wiki.corp.x.com/display/MCOMS/Magento+Filesystem+Decisions
298298
*/
299-
public function uploadAndImport(DataObject $object): Tablerate
299+
public function uploadAndImport(DataObject $object)
300300
{
301301
$filePath = $this->getFilePath($object);
302302
if (!$filePath) {
@@ -335,8 +335,6 @@ public function uploadAndImport(DataObject $object): Tablerate
335335
);
336336
throw new LocalizedException($error);
337337
}
338-
339-
return $this;
340338
}
341339

342340
/**

0 commit comments

Comments
 (0)