MAGETWO-33663: Refactor ConfigurableProduct module to use mutable data object interfaces

    - Fix api-functional test failures

Author: Yu Tang

app/code/Magento/ConfigurableProduct/Model/OptionRepository.php

@@ -122,11 +122,12 @@ public function getList($productSku)
             $prices = $option->getPrices();
             if (is_array($prices)) {
                 foreach ($prices as $price) {
-                    $values[] = $this->optionValueFactory
-                        ->setValueIndex($price['value_index'])
+                    /** @var \Magento\ConfigurableProduct\Api\Data\OptionValueInterface $value */
+                    $value = $this->optionValueFactory->create();
+                    $value->setValueIndex($price['value_index'])
                         ->setPricingValue($price['pricing_value'])
-                        ->setIsPercent($price['is_percent'])
-                        ->create();
+                        ->setIsPercent($price['is_percent']);
+                    $values[] = $value;
                 }
             }
             $option->setValues($values);

app/code/Magento/ConfigurableProduct/Model/Product/Type/Configurable/Attribute.php

@@ -162,7 +162,7 @@ public function getValues()
      */
     public function setAttributeId($attributeId)
     {
-        return $this->setAttributeId(self::KEY_ATTRIBUTE_ID, $attributeId);
+        return $this->setData(self::KEY_ATTRIBUTE_ID, $attributeId);
     }
 
     /**
@@ -171,7 +171,7 @@ public function setAttributeId($attributeId)
      */
     public function setLabel($label)
     {
-        return $this->setAttributeId(self::KEY_LABEL, $label);
+        return $this->setData(self::KEY_LABEL, $label);
     }
 
     /**
@@ -180,7 +180,7 @@ public function setLabel($label)
      */
     public function setType($type)
     {
-        return $this->setAttributeId(self::KEY_TYPE, $type);
+        return $this->setData(self::KEY_TYPE, $type);
     }
 
     /**
@@ -189,7 +189,7 @@ public function setType($type)
      */
     public function setPosition($position)
     {
-        return $this->setAttributeId(self::KEY_POSITION, $position);
+        return $this->setData(self::KEY_POSITION, $position);
     }
 
     /**
@@ -198,7 +198,7 @@ public function setPosition($position)
      */
     public function setIsUseDefault($isUseDefault)
     {
-        return $this->setAttributeId(self::KEY_IS_USE_DEFAULT, $isUseDefault);
+        return $this->setData(self::KEY_IS_USE_DEFAULT, $isUseDefault);
     }
 
     /**
@@ -207,7 +207,7 @@ public function setIsUseDefault($isUseDefault)
      */
     public function setValues(array $values = null)
     {
-        return $this->setAttributeId(self::KEY_VALUES, $values);
+        return $this->setData(self::KEY_VALUES, $values);
     }
     //@codeCoverageIgnoreEnd
 }