AC-9499: Update Symfony dependency packages to the latest LTS versions 6.4

Author: glo17680

lib/internal/Magento/Framework/Code/Reader/ArgumentsReader.php

@@ -5,12 +5,15 @@
  */
 namespace Magento\Framework\Code\Reader;
 
+use Laminas\Code\Reflection\DocBlock\Tag\ParamTag;
+use Laminas\Code\Reflection\DocBlockReflection;
 use Magento\Framework\GetParameterClassTrait;
+use Laminas\Code\Reflection\ParameterReflection;
 
 /**
  * The class arguments reader
  */
-class ArgumentsReader
+class ArgumentsReader extends ParameterReflection
 {
     use GetParameterClassTrait;
 
@@ -26,6 +29,11 @@ class ArgumentsReader
      */
     private $scalarTypesProvider;
 
+    /**
+     * @var ParameterReflection
+     */
+    protected $parameterReflection;
+
     /**
      * @param NamespaceResolver|null $namespaceResolver
      * @param ScalarTypesProvider|null $scalarTypesProvider
@@ -102,17 +110,14 @@ public function getConstructorArguments(\ReflectionClass $class, $groupByPositio
      */
     private function processType(\ReflectionClass $class, \Laminas\Code\Reflection\ParameterReflection $parameter)
     {
+        $this->parameterReflection = $parameter;
         $parameterClass = $this->getParameterClass($parameter);
 
         if ($parameterClass) {
             return NamespaceResolver::NS_SEPARATOR . $parameterClass->getName();
         }
 
-        // In PHP8, $parameterType could be an instance of ReflectionUnionType, which doesn't have isBuiltin method
-        if ($parameterClass === null) {
-            return null;
-        }
-        $type = $parameter->detectType();
+        $type = $this->detectType();
 
         /**
          * $type === null if it is unspecified
@@ -281,4 +286,58 @@ public function getAnnotations(\ReflectionClass $class)
 
         return $annotations;
     }
+
+    /**
+     * ReflectionType does not have an isBuiltin() / getName() method
+     *
+     * @deprecated this method is unreliable, and should not be used: it will be removed in the next major release.
+     *             It may crash on parameters with union types, and will return relative types, instead of
+     *             FQN references
+     *
+     * @return mixed|string|void|null
+     */
+    public function detectType()
+    {
+        if (null !== ($type = $this->parameterReflection->getType())
+            && method_exists($type, 'isBuiltin') && $type->isBuiltin()
+        ) {
+            return $type->getName();
+        }
+
+        if (null !== $type && method_exists($type, 'getName') && $type->getName() === 'self') {
+            $declaringClass = $this->parameterReflection->getDeclaringClass();
+            // @codingStandardsIgnoreStart
+            assert($declaringClass !== null, 'A parameter called `self` can only exist on a class');
+            // @codingStandardsIgnoreEnd
+
+            return $declaringClass->getName();
+        }
+
+        if (($class = $this->parameterReflection->getClass()) instanceof ReflectionClass) {
+            return $class->getName();
+        }
+
+        $docBlock = $this->parameterReflection->getDeclaringFunction()->getDocBlock();
+
+        if (! $docBlock instanceof DocBlockReflection) {
+            return null;
+        }
+
+        /** @var ParamTag[] $params */
+        $params       = $docBlock->getTags('param');
+        $paramTag     = $params[$this->parameterReflection->getPosition()] ?? null;
+        $variableName = '$' . $this->parameterReflection->getName();
+
+        if ($paramTag && ('' === $paramTag->getVariableName() || $variableName === $paramTag->getVariableName())) {
+            return $paramTag->getTypes()[0] ?? '';
+        }
+
+        foreach ($params as $param) {
+            if ($param->getVariableName() === $variableName) {
+                return $param->getTypes()[0] ?? '';
+            }
+        }
+
+        return null;
+    }
 }