MAGETWO-69629: Locking all cronjobs with the same job code

Author: pdohogne-magento

dev/tests/integration/testsuite/Magento/Cron/Model/ScheduleTest.php

@@ -0,0 +1,99 @@
+<?php
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+namespace Magento\Cron\Model;
+
+use Magento\Framework\Stdlib\DateTime\DateTime;
+use \Magento\TestFramework\Helper\Bootstrap;
+
+/**
+ * Test \Magento\Cron\Model\Schedule
+ *
+ * @magentoDbIsolation enabled
+ */
+class ScheduleTest extends \PHPUnit_Framework_TestCase
+{
+    /**
+     * @var ScheduleFactory
+     */
+    private $scheduleFactory;
+
+    /**
+     * @var DateTime
+     */
+    protected $dateTime;
+
+    public function setUp()
+    {
+        $this->dateTime = Bootstrap::getObjectManager()->create(DateTime::class);
+        $this->scheduleFactory = Bootstrap::getObjectManager()->create(ScheduleFactory::class);
+    }
+
+    /**
+     * If there are no currently locked jobs, locking one of them should succeed
+     */
+    public function testTryLockJob_NoLockedJobsSucceeds()
+    {
+        for ($i = 1; $i < 6; $i++) {
+            $this->createSchedule("test_job", Schedule::STATUS_PENDING, 60 * $i);
+        }
+        $schedule = $this->createSchedule("test_job", Schedule::STATUS_PENDING);
+
+        $this->assertTrue($schedule->tryLockJob());
+    }
+
+    /**
+     * If the job is already locked, attempting to lock it again should fail
+     */
+    public function testTryLockJob_AlreadyLockedFails()
+    {
+        $schedule = $this->createSchedule("test_job", Schedule::STATUS_RUNNING);
+
+        $this->assertFalse($schedule->tryLockJob());
+    }
+
+    /**
+     * If there's a job already locked, should not be able to lock another job
+     */
+    public function testTryLockJob_OtherLockedFails()
+    {
+        $this->createSchedule("test_job", Schedule::STATUS_RUNNING);
+        $schedule = $this->createSchedule("test_job", Schedule::STATUS_PENDING, 60);
+
+        $this->assertFalse($schedule->tryLockJob());
+    }
+
+    /**
+     * Should be able to lock a job if a job with a different code is locked
+     */
+    public function testTryLockJob_DifferentJobLocked()
+    {
+        $this->createSchedule("test_job_other", Schedule::STATUS_RUNNING);
+        $schedule = $this->createSchedule("test_job", Schedule::STATUS_PENDING);
+
+        $this->assertTrue($schedule->tryLockJob());
+    }
+
+    /**
+     * Creates a schedule with the given job code, status, and schedule time offset
+     *
+     * @param string $jobCode
+     * @param string $status
+     * @param int $timeOffset
+     * @return Schedule
+     */
+    private function createSchedule($jobCode, $status, $timeOffset = 0)
+    {
+        $schedule = $this->scheduleFactory->create()
+            ->setCronExpr("* * * * *")
+            ->setJobCode($jobCode)
+            ->setStatus($status)
+            ->setCreatedAt(strftime('%Y-%m-%d %H:%M:%S', $this->dateTime->gmtTimestamp()))
+            ->setScheduledAt(strftime('%Y-%m-%d %H:%M', $this->dateTime->gmtTimestamp() + $timeOffset));
+        $schedule->save();
+
+        return $schedule;
+    }
+}