MAGETWO-89051: Absorb image optimization from 2.1 into 2.3

Author: duhon

app/code/Magento/Catalog/Model/ImageExtractor.php

@@ -37,7 +37,7 @@ public function process(\DOMElement $mediaNode, $mediaParentTag)
                 } elseif ($attributeTagName === 'width' || $attributeTagName === 'height') {
                     $nodeValue = intval($attribute->nodeValue);
                 } else {
-                    $nodeValue = $attribute->nodeValue;
+                    $nodeValue = !in_array($attribute->nodeValue, ['false', '0']);
                 }
                 $result[$mediaParentTag][$moduleNameImage][Image::MEDIA_TYPE_CONFIG_NODE][$imageId][$attribute->tagName]
                     = $nodeValue;

app/code/Magento/Catalog/Model/Product/Image/ParamsBuilder.php

@@ -102,13 +102,13 @@ private function overwriteDefaultValues(array $imageArguments): array
         $angle = $imageArguments['angle'] ?? $this->defaultAngle;
 
         return [
-            'background' => $background,
+            'background' => (array) $background,
             'angle' => $angle,
             'quality' => $this->defaultQuality,
-            'keep_aspect_ratio' => $aspectRatio,
+            'keep_aspect_ratio' => (bool) $aspectRatio,
             'keep_frame' => (bool) $frame,
-            'keep_transparency' => $transparency,
-            'constrain_only' => $constrain,
+            'keep_transparency' => (bool) $transparency,
+            'constrain_only' => (bool) $constrain,
         ];
     }
 

app/code/Magento/MediaStorage/Service/ImageResize.php

@@ -219,12 +219,8 @@ private function getViewImages(array $themes): array
     private function getUniqImageIndex(array $imageData): string
     {
         ksort($imageData);
-        $index = '';
         unset($imageData['type']);
-        foreach ($imageData as $key => $data) {
-            $index .= "$key:$data|";
-        }
-        return $index;
+        return md5(serialize($imageData));
     }
 
     /**