MAGETWO-99401: order-related save_after_commit callbacks are not called for guest checkouts

Author: dhorytskyi

app/etc/di.xml

@@ -1777,4 +1777,7 @@
                 type="Magento\Framework\Mail\MimeMessage" />
     <preference for="Magento\Framework\Mail\MimePartInterface"
                 type="Magento\Framework\Mail\MimePart" />
+    <type name="Magento\Framework\DB\Adapter\AdapterInterface">
+        <plugin name="execute_commit_callbacks" type="Magento\Framework\Model\ExecuteCommitCallbacks" />
+    </type>
 </config>

lib/internal/Magento/Framework/Interception/Config/Config.php

@@ -202,7 +202,9 @@ private function initializeUncompiled($classDefinitions = [])
     private function generateIntercepted($classDefinitions)
     {
         $config = [];
-        foreach ($this->_scopeList->getAllScopes() as $scope) {
+        $scopes = $this->_scopeList->getAllScopes();
+        array_unshift($scopes, 'primary');
+        foreach (array_unique($scopes) as $scope) {
             $config = array_replace_recursive($config, $this->_reader->read($scope));
         }
         unset($config['preferences']);

lib/internal/Magento/Framework/Model/ExecuteCommitCallbacks.php

@@ -0,0 +1,51 @@
+<?php
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+declare(strict_types=1);
+
+namespace Magento\Framework\Model;
+
+use Magento\Framework\DB\Adapter\AdapterInterface;
+use Psr\Log\LoggerInterface;
+
+/**
+ * Execute added callbacks for transaction commit.
+ */
+class ExecuteCommitCallbacks
+{
+    /**
+     * @var LoggerInterface
+     */
+    private $logger;
+
+    public function __construct(LoggerInterface $logger)
+    {
+        $this->logger = $logger;
+    }
+
+    /**
+     * Execute callbacks after commit.
+     *
+     * @param AdapterInterface $subject
+     * @param AdapterInterface $result
+     * @return AdapterInterface
+     * @SuppressWarnings(PHPMD.UnusedFormalParameter)
+     */
+    public function afterCommit(AdapterInterface $subject, AdapterInterface $result): AdapterInterface
+    {
+        if ($result->getTransactionLevel() === 0) {
+            $callbacks = CallbackPool::get(spl_object_hash($result));
+            foreach ($callbacks as $callback) {
+                try {
+                    call_user_func($callback);
+                } catch (\Throwable $e) {
+                    $this->logger->critical($e);
+                }
+            }
+        }
+
+        return $result;
+    }
+}

lib/internal/Magento/Framework/Model/ResourceModel/AbstractResource.php

@@ -87,19 +87,7 @@ public function addCommitCallback($callback)
     public function commit()
     {
         $this->getConnection()->commit();
-        /**
-         * Process after commit callbacks
-         */
-        if ($this->getConnection()->getTransactionLevel() === 0) {
-            $callbacks = CallbackPool::get(spl_object_hash($this->getConnection()));
-            try {
-                foreach ($callbacks as $callback) {
-                    call_user_func($callback);
-                }
-            } catch (\Exception $e) {
-                $this->getLogger()->critical($e);
-            }
-        }
+
         return $this;
     }