MAGETWO-87190: Test coverage for critical logic

Author: Sergii Kovalenko

dev/tests/setup-integration/_files/Magento/TestSetupDeclarationModule1/registration.php

@@ -6,7 +6,4 @@
 
 use Magento\Framework\Component\ComponentRegistrar;
 
-$registrar = new ComponentRegistrar();
-if ($registrar->getPath(ComponentRegistrar::MODULE, 'Magento_TestSetupDeclarationModule1') === null) {
-    ComponentRegistrar::register(ComponentRegistrar::MODULE, 'Magento_TestSetupDeclarationModule1', __DIR__);
-}
+ComponentRegistrar::register(ComponentRegistrar::MODULE, 'Magento_TestSetupDeclarationModule1', __DIR__);

dev/tests/setup-integration/framework/Magento/TestFramework/Deploy/TestModuleManager.php

@@ -78,7 +78,7 @@ public function updateRevision($moduleName, $revisionName, $fileName, $fileDir)
 
         if (file_exists($oldFile) && file_exists($revisionFile)) {
             unlink($oldFile);
-            rename($revisionFile, $oldFile);
+            copy($revisionFile, $oldFile);
         } else {
             throw new \InvalidArgumentException("Old File or revision files paths are invalid");
         }

dev/tests/setup-integration/framework/bootstrap.php

@@ -75,8 +75,6 @@
     );
     $bootstrap->runBootstrap();
     $application->createInstallDir();
-    //remove test modules files
-    include_once __DIR__ . '/../../setup-integration/framework/removeTestModules.php';
     //We do not want to install anything
     $application->initialize([]);
 

setup/src/Magento/Setup/Model/Declaration/Schema/Declaration/ReaderComposite.php

@@ -48,11 +48,6 @@ public function read($scope = null)
             $schema = array_replace_recursive($schema, $reader->read($scope));
         }
 
-        if (count($schema['table']) === 0) {
-            var_dump($this->deploymentConfig->get());
-            var_dump($this->deploymentConfig->getConfigData());
-        }
-
         return $schema;
     }
 }