MAGETWO-90106: Paypal cannot place the order when Payment Action = Order

Author: svitja

app/code/Magento/Paypal/Block/Adminhtml/Order/View.php

@@ -17,7 +17,7 @@
 use Magento\Framework\Exception\LocalizedException;
 
 /**
- * Adminhtml sales order view
+ * Adminhtml sales order view.
  * @api
  */
 class View extends OrderView

app/code/Magento/Paypal/Controller/Adminhtml/Express/Authorization.php

@@ -32,7 +32,7 @@
 class Authorization extends Order
 {
     /**
-     * Authorization level of a basic admin session
+     * Authorization level of a basic admin session.
      * @see _isAllowed()
      */
     const ADMIN_RESOURCE = 'Magento_Paypal::authorization';

app/code/Magento/Paypal/Plugin/OrderCanInvoice.php

@@ -38,7 +38,7 @@ public function __construct(Express $express)
      * @return bool
      * @throws \Magento\Framework\Exception\LocalizedException
      */
-    public function afterCanInvoice(Order $order, $result): bool
+    public function afterCanInvoice(Order $order, bool $result): bool
     {
         if ($this->express->isOrderAuthorizationAllowed($order->getPayment())) {
             return false;

app/code/Magento/Paypal/Plugin/ValidatorCanInvoice.php

@@ -43,7 +43,7 @@ public function __construct(Express $express)
      * @throws LocalizedException
      * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
-    public function afterValidate(CanInvoice $subject, $result, OrderInterface $order): array
+    public function afterValidate(CanInvoice $subject, bool $result, OrderInterface $order): array
     {
         if ($this->express->isOrderAuthorizationAllowed($order->getPayment())) {
             $result[] = __('An invoice cannot be created when none of authorization transactions available.');

app/code/Magento/Paypal/Test/Unit/Model/ExpressTest.php

@@ -130,6 +130,8 @@ public function testSetApiProcessableErrors()
 
     /**
      * Tests order payment action.
+     *
+     * @return void
      */
     public function testOrder()
     {

dev/tests/integration/testsuite/Magento/Paypal/Controller/Adminhtml/Express/AuthorizationTest.php

@@ -39,6 +39,8 @@ protected function setUp()
 
     /**
      * Negative scenario for controller calls.
+     *
+     * @return void
      */
     public function testNoOrderPassed()
     {
@@ -53,6 +55,7 @@ public function testNoOrderPassed()
      * @magentoConfigFixture current_store payment/paypal_express/payment_action Order
      * @magentoDataFixture Magento/Paypal/_files/order_express_payment_action_order.php
      * @magentoDbIsolation enabled
+     * @return void
      */
     public function testAuthorization()
     {

dev/tests/integration/testsuite/Magento/Paypal/_files/order_express_payment_action_order.php

@@ -3,7 +3,6 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
-
 declare(strict_types=1);
 
 use Magento\Sales\Model\Order;