Test case updated with if content NULL & fixed health check issue

srsathish92 · srsathish92 · commit a2082260635f · 2020-02-12T01:11:03.000+05:30
diff --git a/app/code/Magento/Theme/Test/Unit/Controller/Result/JsFooterPluginTest.php b/app/code/Magento/Theme/Test/Unit/Controller/Result/JsFooterPluginTest.php
@@ -59,7 +59,7 @@ protected function setUp(): void
     }
 
     /**
-     * Data Provider for beforeSendResponse()
+     * Data Provider for testBeforeSendResponse()
      *
      * @return array
      */
@@ -68,14 +68,14 @@ public function sendResponseDataProvider(): array
         return [
             [
                 "content" => "<body><h1>Test Title</h1>" .
-                    "<script text=\"text/javascript\">test</script>" .
-                    "<script text=\"text/x-magento-template\">test</script>" .
+                    "<script type=\"text/x-magento-init\">test</script>" .
+                    "<script type=\"text/x-magento-template\">test</script>" .
                     "<p>Test Content</p></body>",
                 "flag" => true,
                 "result" => "<body><h1>Test Title</h1>" .
-                    "<script text=\"text/x-magento-template\">test</script>" .
+                    "<script type=\"text/x-magento-template\">test</script>" .
                     "<p>Test Content</p>" .
-                    "<script text=\"text/javascript\">test</script>" .
+                    "<script type=\"text/x-magento-init\">test</script>" .
                     "\n</body>"
             ],
             [
@@ -121,16 +121,35 @@ public function testBeforeSendResponse($content, $isSetFlag, $result): void
         $this->plugin->beforeSendResponse($this->httpMock);
     }
 
+    /**
+     * Data Provider for testBeforeSendResponseIfGetContentIsNotAString()
+     *
+     * @return array
+     */
+    public function ifGetContentIsNotAStringDataProvider(): array
+    {
+        return [
+            [
+                'content' => []
+            ],
+            [
+                'content' => NULL
+            ]
+        ];
+    }
+
     /**
      * Test BeforeSendResponse if content is not a string
      *
+     * @param string $content
      * @return void
+     * @dataProvider ifGetContentIsNotAStringDataProvider
      */
-    public function testBeforeSendResponseIfGetContentIsNotAString(): void
+    public function testBeforeSendResponseIfGetContentIsNotAString($content): void
     {
         $this->httpMock->expects($this->once())
             ->method('getContent')
-            ->willReturn([]);
+            ->willReturn($content);
 
         $this->scopeConfigMock->expects($this->never())
             ->method('isSetFlag')
