MAGETWO-70735: [UX][Security] Missing validation and hint for "Compatible File Extensions" in Custom Option of Type=File

Author: OlgaVasyltsun

app/code/Magento/Catalog/Test/Unit/Model/Product/OptionTest.php

@@ -82,10 +82,7 @@ public function testCleanFileExtensions(string $rawExtensions, string $expectedE
         $this->model->setFileExtension($rawExtensions);
         $this->model->beforeSave();
         $actualExtensions = $this->model->getFileExtension();
-        $this->assertEquals(
-            $expectedExtensions,
-            $actualExtensions
-        );
+        $this->assertEquals($expectedExtensions, $actualExtensions);
     }
 
     /**
@@ -102,7 +99,7 @@ public function cleanFileExtensionsDataProvider()
             ['jpg png gif', 'jpg, png, gif'],
             ['!jpg@png#gif%', 'jpg, png, gif'],
             ['jpg, png, 123', 'jpg, png, 123'],
-            ['', '']
+            ['', ''],
         ];
     }
 }

app/code/Magento/Catalog/Ui/DataProvider/Product/Form/Modifier/CustomOptions.php

@@ -1046,7 +1046,7 @@ protected function getFileExtensionFieldConfig($sortOrder)
                 'data' => [
                     'config' => [
                         'label' => __('Compatible File Extensions'),
-                        'notice' => __('Enter separated extensions, like: png, jpg, gif. Leave blank to allow any.'),
+                        'notice' => __('Enter separated extensions, like: png, jpg, gif.'),
                         'componentType' => Field::NAME,
                         'formElement' => Input::NAME,
                         'dataScope' => static::FIELD_FILE_EXTENSION_NAME,

dev/tests/functional/tests/app/Magento/Catalog/Test/Constraint/AssertCustomOptions.php

@@ -16,7 +16,7 @@
 class AssertCustomOptions extends AssertProductForm
 {
     /**
-     * Assert form data equals fixture data
+     * Assert form data equals fixture data.
      *
      * @param FixtureInterface $product
      * @param CatalogProductIndex $productGrid
@@ -38,8 +38,9 @@ public function processAssert(
         }
         $fixtureData = $this->prepareFixtureData($productData, $this->sortFields);
         $formData = $this->prepareFormData($productPage->getProductForm()->getData($product), $this->sortFields);
-        $error = $this->verifyData($fixtureData, $formData);
-        \PHPUnit\Framework\Assert::assertTrue(empty($error), $error);
+        $errors = $this->verifyData($fixtureData, $formData);
+
+        \PHPUnit\Framework\Assert::assertEmpty($errors, $errors);
     }
 
     /**

dev/tests/functional/tests/app/Magento/Catalog/Test/Constraint/AssertFileExtensionHints.php

@@ -20,7 +20,7 @@ class AssertFileExtensionHints extends AbstractAssertForm
      *
      * @var string
      */
-    const EXPECTED_MESSAGE = 'Enter separated extensions, like: png, jpg, gif. Leave blank to allow any.';
+    const EXPECTED_MESSAGE = 'Enter separated extensions, like: png, jpg, gif.';
 
     /**
      * Assert that file extension message is showed.