Skip to content

Commit a125794

Browse files
ENGCOM-8970: Replace repetitive actions with Action Groups in AdminCreateVirtualProductFillingRequiredFieldsOnlyTest #32477
- Merge Pull Request #32477 from kate-kyzyma/magento2:refactoring-AdminCreateVirtualProductFillingRequiredFieldsOnlyTest - Merged commits: 1. b37d542
2 parents 12ebc0e + b37d542 commit a125794

File tree

1 file changed

+39
-16
lines changed

1 file changed

+39
-16
lines changed

app/code/Magento/Catalog/Test/Mftf/Test/AdminCreateVirtualProductFillingRequiredFieldsOnlyTest.xml

Lines changed: 39 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -25,31 +25,54 @@
2525
<actionGroup ref="AdminLogoutActionGroup" stepKey="logout"/>
2626
</after>
2727

28-
<actionGroup ref="AdminProductCatalogPageOpenActionGroup" stepKey="openProductCatalogPage"/>
29-
<comment userInput="Adding the comment to replace clickAddProductToggle action for preserving Backward Compatibility" stepKey="clickAddProductToggle"/>
30-
<comment userInput="Adding the comment to replace clickAddProductToggle action for preserving Backward Compatibility" stepKey="waitForProductToggleToSelectProduct"/>
31-
<actionGroup ref="AdminClickAddProductToggleAndSelectProductTypeActionGroup" stepKey="clickVirtualProduct">
28+
<comment userInput="Adding the comment to replace clickAddProductToggle action for preserving Backward Compatibility"
29+
stepKey="openProductCatalogPage"/>
30+
<comment userInput="Adding the comment to replace clickAddProductToggle action for preserving Backward Compatibility"
31+
stepKey="clickAddProductToggle"/>
32+
<comment userInput="Adding the comment to replace clickAddProductToggle action for preserving Backward Compatibility"
33+
stepKey="waitForProductToggleToSelectProduct"/>
34+
<actionGroup ref="AdminOpenNewProductFormPageActionGroup" stepKey="clickVirtualProduct">
3235
<argument name="productType" value="virtual"/>
3336
</actionGroup>
3437

3538
<!-- Create virtual product with required fields only -->
36-
<fillField selector="{{AdminProductFormSection.productName}}" userInput="{{virtualProductWithRequiredFields.name}}" stepKey="fillProductName"/>
37-
<fillField selector="{{AdminProductFormSection.productSku}}" userInput="{{virtualProductWithRequiredFields.sku}}" stepKey="fillProductSku"/>
38-
<fillField selector="{{AdminProductFormSection.productPrice}}" userInput="{{virtualProductWithRequiredFields.price}}" stepKey="fillProductPrice"/>
39+
<actionGroup ref="FillProductNameAndSkuInProductFormActionGroup" stepKey="fillProductName">
40+
<argument name="product" value="virtualProductWithRequiredFields"/>
41+
</actionGroup>
42+
<comment userInput="Adding the comment to replace clickAddProductToggle action for preserving Backward Compatibility"
43+
stepKey="fillProductSku"/>
44+
<actionGroup ref="AdminFillProductPriceFieldAndPressEnterOnProductEditPageActionGroup" stepKey="fillProductPrice">
45+
<argument name="price" value="{{virtualProductWithRequiredFields.price}}"/>
46+
</actionGroup>
3947
<actionGroup ref="AdminProductFormSaveButtonClickActionGroup" stepKey="clickSaveButton"/>
4048

4149
<!-- Verify we see success message -->
42-
<see selector="{{AdminProductFormSection.successMessage}}" userInput="You saved the product." stepKey="seeAssertVirtualProductSuccessMessage"/>
50+
<actionGroup ref="AssertMessageInAdminPanelActionGroup" stepKey="seeAssertVirtualProductSuccessMessage">
51+
<argument name="message" value="You saved the product."/>
52+
</actionGroup>
4353

4454
<!-- Verify we see created virtual product(from the above step) on the product grid page -->
4555
<actionGroup ref="AdminProductCatalogPageOpenActionGroup" stepKey="openProductCatalogPage1"/>
46-
<conditionalClick selector="{{AdminProductGridFilterSection.clearAll}}" dependentSelector="{{AdminProductGridFilterSection.clearAll}}" visible="true" stepKey="clickSelector"/>
47-
<click selector="{{AdminProductGridFilterSection.filters}}" stepKey="clickFilter"/>
48-
<fillField selector="{{AdminProductGridFilterSection.nameFilter}}" userInput="{{virtualProductWithRequiredFields.name}}" stepKey="fillProductName1"/>
49-
<fillField selector="{{AdminProductGridFilterSection.skuFilter}}" userInput="{{virtualProductWithRequiredFields.sku}}" stepKey="fillVirtualProductSku"/>
50-
<click selector="{{AdminProductGridFilterSection.applyFilters}}" stepKey="clickSearch2"/>
51-
<waitForPageLoad stepKey="waitForProductSearch"/>
52-
<seeInField selector="{{AdminProductGridFilterSection.nameFilter}}" userInput="{{virtualProductWithRequiredFields.name}}" stepKey="seeVirtualProductName"/>
53-
<seeInField selector="{{AdminProductGridFilterSection.skuFilter}}" userInput="{{virtualProductWithRequiredFields.sku}}" stepKey="seeVirtualProductSku"/>
56+
<comment userInput="Adding the comment to replace clickAddProductToggle action for preserving Backward Compatibility"
57+
stepKey="clickSelector"/>
58+
<comment userInput="Adding the comment to replace clickAddProductToggle action for preserving Backward Compatibility"
59+
stepKey="clickFilter"/>
60+
<comment userInput="Adding the comment to replace clickAddProductToggle action for preserving Backward Compatibility"
61+
stepKey="fillProductName1"/>
62+
<comment userInput="Adding the comment to replace clickAddProductToggle action for preserving Backward Compatibility"
63+
stepKey="fillVirtualProductSku"/>
64+
<actionGroup ref="FilterProductGridBySkuAndNameActionGroup" stepKey="clickSearch2">
65+
<argument name="product" value="virtualProductWithRequiredFields"/>
66+
</actionGroup>
67+
<comment userInput="Adding the comment to replace clickAddProductToggle action for preserving Backward Compatibility"
68+
stepKey="waitForProductSearch"/>
69+
<actionGroup ref="AssertAdminProductGridCellActionGroup" stepKey="seeVirtualProductName">
70+
<argument name="column" value="Name"/>
71+
<argument name="value" value="{{virtualProductWithRequiredFields.name}}"/>
72+
</actionGroup>
73+
<actionGroup ref="AssertAdminProductGridCellActionGroup" stepKey="seeVirtualProductSku">
74+
<argument name="column" value="SKU"/>
75+
<argument name="value" value="{{virtualProductWithRequiredFields.sku}}"/>
76+
</actionGroup>
5477
</test>
5578
</tests>

0 commit comments

Comments
 (0)