Skip to content

Commit a110824

Browse files
author
Serhiy Shkolyarenko
committed
Merge remote-tracking branch 'origin/bugfix' into bugs
2 parents 85760a3 + 2f6a433 commit a110824

File tree

5 files changed

+6
-31
lines changed

5 files changed

+6
-31
lines changed

dev/tests/api-functional/testsuite/Magento/Bundle/Api/ProductOptionRepositoryTest.php

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -147,16 +147,6 @@ public function testAdd()
147147
*/
148148
public function testUpdate()
149149
{
150-
/** TODO: Remove after MAGETWO-40822 */
151-
$isPhpVersionSupported = version_compare(
152-
'7.0.0',
153-
preg_replace('#^([^~+-]+).*$#', '$1', PHP_VERSION),
154-
'>'
155-
);
156-
if (!$isPhpVersionSupported) {
157-
$this->markTestSkipped('MAGETWO-40822');
158-
}
159-
160150
$productSku = 'bundle-product';
161151
$request = [
162152
'title' => 'someTitle',

dev/tests/integration/testsuite/Magento/Sitemap/Helper/DataTest.php

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -14,15 +14,6 @@ class DataTest extends \PHPUnit_Framework_TestCase
1414

1515
protected function setUp()
1616
{
17-
// TODO: Remove provided check after PHPMD will support PHP version 7
18-
$isSupported = version_compare(
19-
'7.0.0',
20-
preg_replace('#^([^~+-]+).*$#', '$1', PHP_VERSION),
21-
'>'
22-
);
23-
if (!$isSupported) {
24-
$this->markTestSkipped('MAGETWO-40822: PHP7 incompatible');
25-
}
2617
$this->_helper = \Magento\TestFramework\Helper\Bootstrap::getObjectManager()->get(
2718
'Magento\Sitemap\Helper\Data'
2819
);

dev/tests/static/framework/Magento/TestFramework/CodingStandard/Tool/CodeMessDetector.php

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -46,9 +46,7 @@ public function __construct($rulesetFile, $reportFile)
4646
*/
4747
public function canRun()
4848
{
49-
/** TODO: Remove provided check after PHPMD will support PHP version 7 */
50-
$isPhpVersionSupported = PHP_VERSION_ID < 70000;
51-
return class_exists('PHPMD\TextUI\Command') && $isPhpVersionSupported;
49+
return class_exists('PHPMD\TextUI\Command');
5250
}
5351

5452
/**

dev/tests/static/framework/tests/unit/testsuite/Magento/TestFramework/CodingStandard/Tool/CodeMessDetectorTest.php

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -14,15 +14,8 @@ public function testCanRun()
1414
'some/report/file.xml'
1515
);
1616

17-
/** TODO: Remove provided check after PHPMD will support PHP version 7 */
18-
$isPhpVersionSupported = version_compare(
19-
'7.0.0',
20-
preg_replace('#^([^~+-]+).*$#', '$1', PHP_VERSION),
21-
'>'
22-
);
23-
2417
$this->assertEquals(
25-
class_exists('PHPMD\TextUI\Command') && $isPhpVersionSupported,
18+
class_exists('PHPMD\TextUI\Command'),
2619
$messDetector->canRun()
2720
);
2821
}

setup/src/Magento/Setup/Controller/Connect.php

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,10 @@ public function __construct(ComposerInformation $composerInformation, ConnectMan
4242
*/
4343
public function saveAuthJsonAction()
4444
{
45-
$params = Json::decode($this->getRequest()->getContent(), Json::TYPE_ARRAY);
45+
$params = [];
46+
if ($this->getRequest()->getContent()) {
47+
$params = Json::decode($this->getRequest()->getContent(), Json::TYPE_ARRAY);
48+
}
4649
try {
4750
$userName = isset($params['username']) ? $params['username'] : '';
4851
$password = isset($params['password']) ? $params['password'] : '';

0 commit comments

Comments
 (0)