MC-31168: [2.3.x] Mark core payment methods as deprecated in Admin

Author: svitja

app/code/Magento/Authorizenet/etc/adminhtml/system.xml

@@ -10,6 +10,7 @@
         <section id="payment">
             <group id="authorizenet_directpost" translate="label" type="text" sortOrder="34" showInDefault="1" showInWebsite="1" showInStore="1">
                 <label>Authorize.Net Direct Post (Deprecated)</label>
+                <attribute type="displayIn">deprecated_payment_methods</attribute>
                 <field id="active" translate="label" type="select" sortOrder="10" showInDefault="1" showInWebsite="1" showInStore="0" canRestore="1">
                     <label>Enabled</label>
                     <source_model>Magento\Config\Model\Config\Source\Yesno</source_model>

app/code/Magento/AuthorizenetAcceptjs/etc/adminhtml/system.xml

@@ -10,6 +10,7 @@
         <section id="payment">
             <group id="authorizenet_acceptjs" translate="label" type="text" sortOrder="34" showInDefault="1" showInWebsite="1" showInStore="1">
                 <label>Authorize.Net (Deprecated)</label>
+                <attribute type="displayIn">deprecated_payment_methods</attribute>
                 <field id="active" translate="label" type="select" sortOrder="10" showInDefault="1" showInWebsite="1" showInStore="0" canRestore="1">
                     <label>Enabled</label>
                     <source_model>Magento\Config\Model\Config\Source\Yesno</source_model>

app/code/Magento/Paypal/Model/Config/Structure/PaymentSectionModifier.php

@@ -20,6 +20,7 @@ class PaymentSectionModifier
         'recommended_solutions',
         'other_paypal_payment_solutions',
         'other_payment_methods',
+        'deprecated_payment_methods',
     ];
 
     /**

app/code/Magento/Paypal/Test/Unit/Model/Config/Structure/PaymentSectionModifierTest.php

@@ -15,6 +15,7 @@ class PaymentSectionModifierTest extends \PHPUnit\Framework\TestCase
         'recommended_solutions',
         'other_paypal_payment_solutions',
         'other_payment_methods',
+        'deprecated_payment_methods',
     ];
 
     /**
@@ -145,6 +146,7 @@ public function testMovedToTargetSpecialGroup()
                         ],
                     ],
                 ],
+                'deprecated_payment_methods' => [],
             ],
             $modifiedStructure,
             'Some group is not moved correctly'

app/code/Magento/Paypal/etc/adminhtml/system.xml

@@ -36,6 +36,13 @@
                 <fieldset_css>paypal-top-section payments-other-header</fieldset_css>
                 <frontend_model>\Magento\Config\Block\System\Config\Form\Fieldset</frontend_model>
             </group>
+            <group id="deprecated_payment_methods" translate="label" sortOrder="5" showInDefault="1" showInWebsite="1" showInStore="1">
+                <label>Deprecated Payment Methods:</label>
+                <comment><![CDATA[<b>Note:</b> These payment methods have been deprecated because they are no longer compliant. We recommend that these payment method to be disabled to prevent new orders, since the payment processor might not support them. Please migrate to the official payment methods extensions from Magento Marketplace instead and disable deprecated payment integrations as soon as possible.]]></comment>
+                <attribute type="expanded">1</attribute>
+                <fieldset_css>paypal-top-section payments-other-header deprecated-message</fieldset_css>
+                <frontend_model>\Magento\Config\Block\System\Config\Form\Fieldset</frontend_model>
+            </group>
         </section>
         <section id="payment_all_paypal" showInDefault="0" showInWebsite="0" showInStore="0">
             <include path="Magento_Paypal::system/paypal_payflowpro.xml"/>
@@ -381,5 +388,8 @@
                 <group id="paypal_payflowpro_nz" extends="payment_all_paypal/paypal_payflowpro"/>
             </group>
         </section>
+        <section id="deprecated_payment_methods" extends="payment" showInDefault="0" showInWebsite="0" showInStore="0">
+            <label>Deprecated Payment Methods:</label>
+        </section>
     </system>
 </config>

app/design/adminhtml/Magento/backend/Magento_Config/web/css/source/_module.less

@@ -148,3 +148,13 @@
         }
     }
 }
+
+.deprecated-message > .comment {
+    background: #faecec;
+    border: 1px solid #d6474a;
+    border-radius: 3px;
+    color: #d6474a;
+    margin: 5px 0 0;
+    padding: 3px 7px;
+    position: relative;
+}