MAGETWO-93188: Product date attribute: An error displays for default date greater than 12 with local using dd/mm/yyyy

Author: olysenko

app/code/Magento/Captcha/Test/Unit/Model/Customer/Plugin/AjaxLoginTest.php

@@ -58,6 +58,9 @@ class AjaxLoginTest extends \PHPUnit\Framework\TestCase
      */
     protected $model;
 
+    /**
+     * @inheritdoc
+     */
     protected function setUp()
     {
         $this->sessionManagerMock = $this->createPartialMock(\Magento\Checkout\Model\Session::class, ['setUsername']);
@@ -91,6 +94,9 @@ protected function setUp()
         );
     }
 
+    /**
+     * Test aroundExecute.
+     */
     public function testAroundExecute()
     {
         $username = 'name';
@@ -123,6 +129,9 @@ public function testAroundExecute()
         $this->assertEquals('result', $this->model->aroundExecute($this->loginControllerMock, $closure));
     }
 
+    /**
+     * Test aroundExecuteIncorrectCaptcha.
+     */
     public function testAroundExecuteIncorrectCaptcha()
     {
         $username = 'name';

app/code/Magento/Catalog/Controller/Adminhtml/Product/Initialization/Helper.php

@@ -104,7 +104,7 @@ class Helper
      * @param \Magento\Backend\Helper\Js $jsHelper
      * @param \Magento\Framework\Stdlib\DateTime\Filter\Date $dateFilter
      * @param CustomOptionFactory|null $customOptionFactory
-     * @param ProductLinkFactory |null $productLinkFactory
+     * @param ProductLinkFactory|null $productLinkFactory
      * @param ProductRepositoryInterface|null $productRepository
      * @param LinkTypeProvider|null $linkTypeProvider
      * @param AttributeFilter|null $attributeFilter

app/code/Magento/Catalog/Test/Unit/Controller/Adminhtml/Product/Initialization/HelperTest.php

@@ -95,6 +95,9 @@ class HelperTest extends \PHPUnit\Framework\TestCase
      */
     protected $attributeFilterMock;
 
+    /**
+     * @inheritdoc
+     */
     protected function setUp()
     {
         $this->objectManager = new ObjectManager($this);

app/code/Magento/Catalog/Test/Unit/Model/Category/Attribute/Backend/ImageTest.php

@@ -34,6 +34,9 @@ class ImageTest extends \PHPUnit\Framework\TestCase
      */
     private $filesystem;
 
+    /**
+     * @inheritdoc
+     */
     protected function setUp()
     {
         $this->objectManager = new \Magento\Framework\TestFramework\Unit\Helper\ObjectManager($this);
@@ -138,6 +141,9 @@ public function testBeforeSaveValueInvalid($value)
         $this->assertEquals('', $object->getTestAttribute());
     }
 
+    /**
+     * Test beforeSaveAttributeFileName.
+     */
     public function testBeforeSaveAttributeFileName()
     {
         $model = $this->objectManager->getObject(\Magento\Catalog\Model\Category\Attribute\Backend\Image::class);
@@ -154,6 +160,9 @@ public function testBeforeSaveAttributeFileName()
         $this->assertEquals('test123.jpg', $object->getTestAttribute());
     }
 
+    /**
+     * Test beforeSaveAttributeFileNameOutsideOfCategoryDir.
+     */
     public function testBeforeSaveAttributeFileNameOutsideOfCategoryDir()
     {
         $model = $this->objectManager->getObject(\Magento\Catalog\Model\Category\Attribute\Backend\Image::class, [
@@ -186,6 +195,9 @@ public function testBeforeSaveAttributeFileNameOutsideOfCategoryDir()
         );
     }
 
+    /**
+     * Test beforeSaveTemporaryAttribute.
+     */
     public function testBeforeSaveTemporaryAttribute()
     {
         $model = $this->objectManager->getObject(\Magento\Catalog\Model\Category\Attribute\Backend\Image::class);
@@ -204,6 +216,9 @@ public function testBeforeSaveTemporaryAttribute()
         ], $object->getData('_additional_data_test_attribute'));
     }
 
+    /**
+     * Test beforeSaveAttributeStringValue.
+     */
     public function testBeforeSaveAttributeStringValue()
     {
         $model = $this->objectManager->getObject(\Magento\Catalog\Model\Category\Attribute\Backend\Image::class);
@@ -304,6 +319,9 @@ public function testAfterSaveWithoutAdditionalData($value)
         $model->afterSave($object);
     }
 
+    /**
+     * Test afterSaveWithExceptions.
+     */
     public function testAfterSaveWithExceptions()
     {
         $model = $this->setUpModelForAfterSave();

dev/tests/integration/testsuite/Magento/Eav/Model/Entity/AttributeTest.php

@@ -28,13 +28,19 @@ class AttributeTest extends \PHPUnit\Framework\TestCase
      */
     private $_localeResolver;
 
+    /**
+     * {@inheritdoc}
+     */
     protected function setUp()
     {
         $this->objectManager = Bootstrap::getObjectManager();
         $this->attribute = $this->objectManager->get(Attribute::class);
         $this->_localeResolver = $this->objectManager->get(ResolverInterface::class);
     }
 
+    /**
+     * {@inheritdoc}
+     */
     protected function tearDown()
     {
         $this->attribute = null;
@@ -60,6 +66,11 @@ public function testBeforeSave($defaultValue, $backendType, $locale, $expected)
         $this->assertEquals($expected, $this->attribute->getDefaultValue());
     }
 
+    /**
+     * Data provider for beforeSaveData.
+     *
+     * @return array
+     */
     public function beforeSaveDataProvider()
     {
         return [
@@ -91,6 +102,11 @@ public function testBeforeSaveErrorData($defaultValue, $backendType, $locale, $e
         $this->expectExceptionMessage($expected);
     }
 
+    /**
+     * Data provider for beforeSaveData with error result.
+     *
+     * @return array
+     */
     public function beforeSaveErrorDataDataProvider()
     {
         return [