Skip to content

Commit a01c4dc

Browse files
author
Kostiantyn Poida
committed
Merge remote-tracking branch 'remotes/origin/MAGETWO-31559' into develop
Conflicts: app/code/Magento/Paypal/Helper/Shortcut/CheckoutValidator.php app/code/Magento/Paypal/Model/Express/Checkout.php app/code/Magento/Sales/Api/Data/OrderItemInterface.php dev/tests/integration/testsuite/Magento/Paypal/Model/Express/CheckoutTest.php dev/tests/static/testsuite/Magento/Test/Legacy/_files/obsolete_classes.php dev/tests/static/testsuite/Magento/Test/Legacy/_files/obsolete_methods.php dev/tests/unit/testsuite/Magento/Paypal/Helper/Shortcut/CheckoutValidatorTest.php
2 parents 573942e + c8e1812 commit a01c4dc

File tree

57 files changed

+438
-1187
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

57 files changed

+438
-1187
lines changed

app/code/Magento/Checkout/Block/Total/Nominal.php

Lines changed: 0 additions & 140 deletions
This file was deleted.

app/code/Magento/Checkout/etc/sales.xml

Lines changed: 0 additions & 15 deletions
This file was deleted.

app/code/Magento/Checkout/view/frontend/templates/total/nominal.phtml

Lines changed: 0 additions & 32 deletions
This file was deleted.

app/code/Magento/Multishipping/Helper/Data.php

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,6 @@ public function isMultishippingCheckoutAvailable()
8686
true
8787
) &&
8888
$quote->getItemsSummaryQty() - $quote->getItemVirtualQty() > 0 &&
89-
$quote->getItemsSummaryQty() <= $this->getMaximumQty() &&
90-
!$quote->hasNominalItems();
89+
$quote->getItemsSummaryQty() <= $this->getMaximumQty();
9190
}
9291
}

app/code/Magento/Payment/Model/Cart/SalesModel/Quote.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ public function getAllItems()
4949
'parent_item' => $item->getParentItem(),
5050
'name' => $item->getName(),
5151
'qty' => (int)$item->getTotalQty(),
52-
'price' => $item->isNominal() ? 0 : (double)$item->getBaseCalculationPrice(),
52+
'price' => (double)$item->getBaseCalculationPrice(),
5353
'original_item' => $item,
5454
]
5555
);

app/code/Magento/Sales/Api/Data/OrderItemInterface.php

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -264,13 +264,7 @@ interface OrderItemInterface extends \Magento\Framework\Api\ExtensibleDataInterf
264264
* Base hidden tax refunded.
265265
*/
266266
const BASE_HIDDEN_TAX_REFUNDED = 'base_hidden_tax_refunded';
267-
/*
268-
* Is-nominal flag.
269-
*/
270267
const IS_NOMINAL = 'is_nominal';
271-
/*
272-
* Tax-canceled flag.
273-
*/
274268
const TAX_CANCELED = 'tax_canceled';
275269
/*
276270
* Hidden-tax-canceled flag.
@@ -750,13 +744,6 @@ public function getHiddenTaxInvoiced();
750744
*/
751745
public function getHiddenTaxRefunded();
752746

753-
/**
754-
* Gets the is-nominal flag value for the order item.
755-
*
756-
* @return int Is-nominal flag value.
757-
*/
758-
public function getIsNominal();
759-
760747
/**
761748
* Gets the is-quantity-decimal flag value for the order item.
762749
*

app/code/Magento/Sales/Model/Config.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ public function getTotalsRenderer($section, $group, $code)
4848

4949
/**
5050
* Retrieve totals for group
51-
* e.g. quote, nominal_totals, etc
51+
* e.g. quote, etc
5252
*
5353
* @param string $section
5454
* @param string $group

app/code/Magento/Sales/Model/Config/Converter.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
*/
55

66
/**
7-
* Converts sales totals (incl. nominal, creditmemo, invoice) from \DOMDocument to array
7+
* Converts sales totals (incl. creditmemo, invoice) from \DOMDocument to array
88
*/
99
namespace Magento\Sales\Model\Config;
1010

app/code/Magento/Sales/Model/Config/Reader.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
*/
55

66
/**
7-
* Sales configuration filesystem loader. Loads all totals (incl. nominal, creditmemo, invoice)
7+
* Sales configuration filesystem loader. Loads all totals (incl. creditmemo, invoice)
88
* configuration from XML file
99
*/
1010
namespace Magento\Sales\Model\Config;

app/code/Magento/Sales/Model/ConfigInterface.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ public function getTotalsRenderer($section, $group, $code);
1818

1919
/**
2020
* Retrieve totals for group
21-
* e.g. quote, nominal_totals, etc
21+
* e.g. quote, etc
2222
*
2323
* @param string $section
2424
* @param string $group

0 commit comments

Comments
 (0)