PHPStan add support of magic methods of Data Object.

Get rid of magic numbers.

Author: oleksandrkravchuk

dev/tests/static/framework/Magento/PhpStan/Reflection/Php/DataObjectClassReflectionExtension.php

@@ -20,7 +20,14 @@
  */
 class DataObjectClassReflectionExtension implements MethodsClassReflectionExtension
 {
-    private const MAGIC_METHODS_PREFIXES = ['get', 'set', 'uns', 'has'];
+    private const MAGIC_METHODS_PREFIXES = [
+        'get',
+        'set',
+        'uns',
+        'has'
+    ];
+
+    private const PREFIX_LENGTH = 3;
 
     /**
      * @var Container
@@ -57,22 +64,32 @@ public function hasMethod(ClassReflection $classReflection, string $methodName):
             // In case when annotation already available for the method, we will not use 'magic methods' approach.
             return false;
         }
-
         if ($classReflection->isSubclassOf(DataObject::class) || $classReflection->getName() == DataObject::class) {
-            return in_array(substr($methodName, 0, 3), self::MAGIC_METHODS_PREFIXES);
+            return in_array($this->getPrefix($methodName), self::MAGIC_METHODS_PREFIXES);
         }
-
         /** SessionManager redirects all calls to `__call` to container which extends DataObject */
         if ($classReflection->isSubclassOf(SessionManager::class)
             || $classReflection->getName() === SessionManager::class
         ) {
             /** @see \Magento\Framework\Session\SessionManager::__call */
-            return in_array(substr($methodName, 0, 3), self::MAGIC_METHODS_PREFIXES);
+            return in_array($this->getPrefix($methodName), self::MAGIC_METHODS_PREFIXES);
         }
 
         return false;
     }
 
+    /**
+     * Get prefix from method name.
+     *
+     * @param string $methodName
+     *
+     * @return string
+     */
+    private function getPrefix(string $methodName): string
+    {
+        return (string)substr($methodName, 0, self::PREFIX_LENGTH);
+    }
+
     /**
      * Get method reflection instance.
      *

dev/tests/static/framework/Magento/PhpStan/Reflection/Php/DataObjectMethodReflection.php

@@ -30,6 +30,8 @@
  */
 class DataObjectMethodReflection implements MethodReflection
 {
+    private const PREFIX_LENGTH = 3;
+
     /**
      * @var ClassReflection
      */
@@ -138,6 +140,16 @@ public function getVariants(): array
         ];
     }
 
+    /**
+     * Get prefix from method name.
+     *
+     * @return string
+     */
+    private function getMethodNamePrefix(): string
+    {
+        return (string)substr($this->methodName, 0, self::PREFIX_LENGTH);
+    }
+
     /**
      * Get Magic Methods parameters.
      *
@@ -146,7 +158,7 @@ public function getVariants(): array
     private function getMethodParameters(): array
     {
         $params = [];
-        switch (substr($this->methodName, 0, 3)) {
+        switch ($this->getMethodNamePrefix()) {
             case 'set':
                 $params[] = new DummyParameter(
                     'value',
@@ -179,7 +191,7 @@ private function getMethodParameters(): array
      */
     private function getReturnType(): Type
     {
-        switch (substr($this->methodName, 0, 3)) {
+        switch ($this->getMethodNamePrefix()) {
             case 'set':
             case 'uns':
                 $returnType = new ObjectType($this->classReflection->getName());