MAGETWO-89540: Static CompilerTest doesn't understand nullable type hint

Author: Oleksandr Gorkun

dev/tests/integration/testsuite/Magento/Framework/Code/Reader/SourceArgumentsReaderTest.php

@@ -44,6 +44,8 @@ public function getConstructorArgumentTypesDataProvider()
                     '\Imported\Name\Space\ClassName\Under\Test',
                     '\Imported\Name\Space\ClassName',
                     '\Some\Testing\Name\Space\Test',
+                    '\Exception',
+                    '\Imported\Name\Space\ClassName',
                     'array',
                     ''
                 ],

dev/tests/integration/testsuite/Magento/Framework/Code/Reader/_files/SourceArgumentsReaderTest.php.sample

@@ -19,6 +19,8 @@ class AnotherSimpleClass
         ClassName\Under\Test $itemFive,
         ClassName $itemSix,
         Test $itemSeven,
+        ?\Exception $optionalException,
+        ?ClassName $optionalWithDefaultValue = null,
         array $itemEight = [],
         $itemNine = 'test'
     ) {

lib/internal/Magento/Framework/Code/Reader/SourceArgumentsReader.php

@@ -56,7 +56,7 @@ public function getConstructorArgumentTypes(\ReflectionClass $class, $inherited
         $source = '<?php ' . trim(implode('', $fileContent));
 
         // Remove parameter default value.
-        $source = preg_replace("/ = (.*)/", ',)', $source);
+        $source = preg_replace("/(\s*)=([^\,\)]*)/", '', $source);
 
         $methodTokenized = token_get_all($source);
         $argumentsStart = array_search('(', $methodTokenized) + 1;
@@ -85,6 +85,9 @@ public function getConstructorArgumentTypes(\ReflectionClass $class, $inherited
         foreach ($arguments as $key => &$argument) {
             $argument = $this->removeToken($argument, '=');
             $argument = $this->removeToken($argument, '&');
+            if (mb_strpos($argument, '?') === 0) {
+                $argument = mb_substr($argument, 1);
+            }
             $argument = $this->namespaceResolver->resolveNamespace($argument, $availableNamespaces);
         }
         unset($argument);