MAGETWO-32315: Side Panels

- Fixed integration test & CR Minor

Author: Oleg Zinoviev

app/code/Magento/Backend/view/adminhtml/templates/widget/tabs.phtml

@@ -27,10 +27,7 @@
                 <?php $_tabHref = $block->getTabUrl($_tab) == '#' ? '#' . $block->getTabId($_tab) . '_content' : $block->getTabUrl($_tab) ?>
 
                 <li class="admin__page-nav-item" <?php if ($block->getTabIsHidden($_tab)): ?> style="display:none"<?php endif; ?><?php echo $block->getUiId('tab', 'item', $_tab->getId()) ?>>
-                    <a href="<?php echo $_tabHref ?>"
-                       id="<?php echo $block->getTabId($_tab) ?>"
-                       name="<?php echo $block->getTabId($_tab, false) ?>"
-                       title="<?php echo $block->getTabTitle($_tab) ?>"
+                    <a href="<?php echo $_tabHref ?>" id="<?php echo $block->getTabId($_tab) ?>" name="<?php echo $block->getTabId($_tab, false) ?>" title="<?php echo $block->getTabTitle($_tab) ?>"
                        class="admin__page-nav-link <?php echo $_tabClass;?>"
                        data-tab-type="<?php echo $_tabType;?>"
                        <?php echo $block->getUiId('tab', 'link', $_tab->getId()) ?>>

dev/tests/integration/testsuite/Magento/Config/Controller/Adminhtml/System/ConfigTest.php

@@ -18,7 +18,7 @@ class ConfigTest extends \Magento\Backend\Utility\Controller
     public function testEditAction()
     {
         $this->dispatch('backend/admin/system_config/edit');
-        $this->assertContains('<ul id="system_config_tabs"', $this->getResponse()->getBody());
+        $this->assertContains('<div id="system_config_tabs"', $this->getResponse()->getBody());
     }
 
     /**

lib/web/mage/backend/tabs.js

@@ -302,11 +302,9 @@
                     .find('.admin__page-nav-item-messages')
                     .clone()
                     .appendTo(curItemMessages);
-
-                curItemMessage = curItemMessages.find('.'+messageType).addClass(activeClass);
-            } else {
-                curItemMessage = curItemMessages.find('.'+messageType).addClass(activeClass);
             }
+
+            curItemMessage = curItemMessages.find('.'+messageType).addClass(activeClass);
         },
 
         /**
@@ -317,7 +315,7 @@
         _onInvalid: function(e) {
             var cssError = '_error';
 
-            this.anchors.eq(e.data.index).addClass(cssError).find(cssError).show();
+            this.anchors.eq(e.data.index).addClass(cssError).find('.'+cssError).show();
             this._updateNavTitleMessages(e, cssError);
         },