Skip to content

Commit 9f35dfb

Browse files
author
Hayder Sharhan
committed
MAGETWO-51801: PR Creation & Stabilization
- To keep placeholder in place.
1 parent 5e6a571 commit 9f35dfb

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

app/code/Magento/Theme/i18n/en_US.csv

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ Hour,Hour
123123
Minute,Minute
124124
"We could not detect a size.","We could not detect a size."
125125
"We don't recognize this file extension.","We don't recognize this file extension."
126-
"Welcome, ","Welcome, "
126+
"Welcome, %1!","--Welcome, %1!"
127127
Empty,Empty
128128
"1 column","1 column"
129129
Configuration,Configuration

app/code/Magento/Theme/view/frontend/templates/html/header.phtml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,7 @@ $welcomeMessage = $block->getWelcome();
1515
case 'welcome': ?>
1616
<li class="greet welcome" data-bind="scope: 'customer'">
1717
<!-- ko if: customer().fullname -->
18-
<span><?php /* @noEscape */ echo __('Welcome, ');?></span>
19-
<span><!-- ko text: customer().firstname + '!' --><!-- /ko --></span>
18+
<span data-bind="text: new String('<?php echo __('Welcome, %1!', '%1');?>').replace('%1', customer().firstname)"></span>
2019
<!-- /ko -->
2120
<!-- ko ifnot: customer().fullname -->
2221
<span data-bind="html:'<?=$block->escapeHtml($welcomeMessage) ?>'"></span>

0 commit comments

Comments
 (0)