REPO-66: [EQP][Sniffs Consolidation] Deliver Magento Coding Standard to magento2ce

lenaorobei · lenaorobei · commit 9ee635ddc636 · 2019-03-28T14:18:07.000-05:00
- review fixes
diff --git a/app/code/Magento/Config/Observer/Config/Backend/Admin/AfterCustomUrlChangedObserver.php b/app/code/Magento/Config/Observer/Config/Backend/Admin/AfterCustomUrlChangedObserver.php
@@ -8,7 +8,7 @@
 use Magento\Framework\Event\ObserverInterface;
 
 /**
- * Class AfterCustomUrlChangedObserver
+ * Class AfterCustomUrlChangedObserver redirects to new custom admin URL.
  *
  * @SuppressWarnings(PHPMD.CookieAndSessionMisuse)
  */
diff --git a/app/code/Magento/Customer/Controller/Adminhtml/Index/Viewfile.php b/app/code/Magento/Customer/Controller/Adminhtml/Index/Viewfile.php
@@ -17,7 +17,7 @@
 use Magento\Framework\DataObjectFactory;
 
 /**
- * Class Viewfile
+ * Class Viewfile serves to show file or image by file/image name provided in request parameters.
  *
  * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
  * @SuppressWarnings(PHPMD.AllPurposeAction)
diff --git a/app/code/Magento/Downloadable/Controller/Download/Link.php b/app/code/Magento/Downloadable/Controller/Download/Link.php
@@ -10,7 +10,7 @@
 use Magento\Framework\App\ResponseInterface;
 
 /**
- * Class Link
+ * Class Link executes download link action.
  *
  * @SuppressWarnings(PHPMD.AllPurposeAction)
  */
diff --git a/app/code/Magento/Downloadable/Controller/Download/LinkSample.php b/app/code/Magento/Downloadable/Controller/Download/LinkSample.php
@@ -9,7 +9,7 @@
 use Magento\Framework\App\ResponseInterface;
 
 /**
- * Class LinkSample
+ * Class LinkSample executes download sample link action.
  *
  * @SuppressWarnings(PHPMD.AllPurposeAction)
  */
diff --git a/app/code/Magento/Downloadable/Controller/Download/Sample.php b/app/code/Magento/Downloadable/Controller/Download/Sample.php
@@ -9,7 +9,7 @@
 use Magento\Framework\App\ResponseInterface;
 
 /**
- * Class Sample
+ * Class Sample executes download sample action.
  *
  * @SuppressWarnings(PHPMD.AllPurposeAction)
  */
diff --git a/dev/tests/integration/testsuite/Magento/Framework/Code/GeneratorTest/ParentClassWithNamespace.php b/dev/tests/integration/testsuite/Magento/Framework/Code/GeneratorTest/ParentClassWithNamespace.php
@@ -8,8 +8,6 @@
 use Zend\Code\Generator\DocBlockGenerator;
 
 /**
- * Class ParentClassWithNamespace
- *
  * phpcs:ignoreFile
  */
 class ParentClassWithNamespace
diff --git a/dev/tests/integration/testsuite/Magento/Framework/Code/GeneratorTest/SourceClassWithNamespace.php b/dev/tests/integration/testsuite/Magento/Framework/Code/GeneratorTest/SourceClassWithNamespace.php
@@ -8,7 +8,6 @@
 use Zend\Code\Generator\ClassGenerator;
 
 /**
- * Class  SourceClassWithNamespace
  * phpcs:ignoreFile
  */
 class SourceClassWithNamespace extends ParentClassWithNamespace
diff --git a/lib/internal/Magento/Framework/App/Console/Response.php b/lib/internal/Magento/Framework/App/Console/Response.php
@@ -6,7 +6,7 @@
 namespace Magento\Framework\App\Console;
 
 /**
- * Class Response
+ * HTTP response implementation.
  */
 class Response implements \Magento\Framework\App\ResponseInterface
 {
diff --git a/lib/internal/Magento/Framework/App/Response/Http/FileFactory.php b/lib/internal/Magento/Framework/App/Response/Http/FileFactory.php
@@ -8,7 +8,7 @@
 use Magento\Framework\App\Filesystem\DirectoryList;
 
 /**
- * Class FileFactory
+ * Class FileFactory serves to declare file content in response for download.
  */
 class FileFactory
 {
diff --git a/lib/internal/Magento/Framework/Code/Test/Unit/Generator/TestAsset/ParentClass.php b/lib/internal/Magento/Framework/Code/Test/Unit/Generator/TestAsset/ParentClass.php
@@ -8,8 +8,6 @@
 use Zend\Code\Generator\DocBlockGenerator;
 
 /**
- * Class ParentClass
- *
  * phpcs:ignoreFile
  */
 class ParentClass
diff --git a/lib/internal/Magento/Framework/Code/Test/Unit/Generator/TestAsset/SourceClass.php b/lib/internal/Magento/Framework/Code/Test/Unit/Generator/TestAsset/SourceClass.php
@@ -8,8 +8,6 @@
 use Zend\Code\Generator\ClassGenerator;
 
 /**
- * Class SourceClass
- *
  * phpcs:ignoreFile
  */
 class SourceClass extends ParentClass

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`use Magento\Framework\Event\ObserverInterface;`
`9`	`9`
`10`	`10`	`/**`
`11`		`- * Class AfterCustomUrlChangedObserver`
	`11`	`+ * Class AfterCustomUrlChangedObserver redirects to new custom admin URL.`
`12`	`12`	`*`
`13`	`13`	`* @SuppressWarnings(PHPMD.CookieAndSessionMisuse)`
`14`	`14`	`*/`
Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,7 @@`
`17`	`17`	`use Magento\Framework\DataObjectFactory;`
`18`	`18`
`19`	`19`	`/**`
`20`		`- * Class Viewfile`
	`20`	`+ * Class Viewfile serves to show file or image by file/image name provided in request parameters.`
`21`	`21`	`*`
`22`	`22`	`* @SuppressWarnings(PHPMD.CouplingBetweenObjects)`
`23`	`23`	`* @SuppressWarnings(PHPMD.AllPurposeAction)`
Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,7 @@`
`10`	`10`	`use Magento\Framework\App\ResponseInterface;`
`11`	`11`
`12`	`12`	`/**`
`13`		`- * Class Link`
	`13`	`+ * Class Link executes download link action.`
`14`	`14`	`*`
`15`	`15`	`* @SuppressWarnings(PHPMD.AllPurposeAction)`
`16`	`16`	`*/`
Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,7 @@`
`9`	`9`	`use Magento\Framework\App\ResponseInterface;`
`10`	`10`
`11`	`11`	`/**`
`12`		`- * Class LinkSample`
	`12`	`+ * Class LinkSample executes download sample link action.`
`13`	`13`	`*`
`14`	`14`	`* @SuppressWarnings(PHPMD.AllPurposeAction)`
`15`	`15`	`*/`
Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,7 @@`
`6`	`6`	`namespace Magento\Framework\App\Console;`
`7`	`7`
`8`	`8`	`/**`
`9`		`- * Class Response`
	`9`	`+ * HTTP response implementation.`
`10`	`10`	`*/`
`11`	`11`	`class Response implements \Magento\Framework\App\ResponseInterface`
`12`	`12`	`{`
Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`use Magento\Framework\App\Filesystem\DirectoryList;`
`9`	`9`
`10`	`10`	`/**`
`11`		`- * Class FileFactory`
	`11`	`+ * Class FileFactory serves to declare file content in response for download.`
`12`	`12`	`*/`
`13`	`13`	`class FileFactory`
`14`	`14`	`{`