AC-1228::BN Code for all Paypal methods

Author: rimple-saini

app/code/Magento/Paypal/Model/SmartButtonConfig.php

@@ -12,7 +12,7 @@
 use Magento\Framework\Locale\ResolverInterface;
 use Magento\Store\Model\ScopeInterface;
 use Magento\Store\Model\StoreManagerInterface;
-use Magento\Paypal\Model\Payflowpro;
+use Magento\Paypal\Model\Config as PaypalConfig;
 
 /**
  * Provides configuration values for PayPal in-context checkout
@@ -45,24 +45,24 @@ class SmartButtonConfig
     private $sdkUrl;
 
     /**
-     * @var Payflowpro
+     * @var PaypalConfig
      */
-    private $payflowpro;
+    private $paypalConfig;
 
     /**
      * @param ResolverInterface $localeResolver
      * @param ConfigFactory $configFactory
      * @param ScopeConfigInterface $scopeConfig
      * @param SdkUrl $sdkUrl
-     * @param Payflowpro $payflowpro
+     * @param PaypalConfig $paypalConfig
      * @param array $defaultStyles
      */
     public function __construct(
         ResolverInterface $localeResolver,
         ConfigFactory $configFactory,
         ScopeConfigInterface $scopeConfig,
         SdkUrl $sdkUrl,
-        Payflowpro $payflowpro,
+        PaypalConfig $paypalConfig,
         $defaultStyles = []
     ) {
         $this->localeResolver = $localeResolver;
@@ -71,7 +71,7 @@ public function __construct(
         $this->scopeConfig = $scopeConfig;
         $this->defaultStyles = $defaultStyles;
         $this->sdkUrl = $sdkUrl;
-        $this->payflowpro = $payflowpro;
+        $this->paypalConfig = $paypalConfig;
     }
 
     /**
@@ -86,14 +86,13 @@ public function getConfig(string $page): array
             Data::XML_PATH_GUEST_CHECKOUT,
             ScopeInterface::SCOPE_STORE
         );
-        $config = $this->payflowpro->getConfig();
         return [
             'styles' => $this->getButtonStyles($page),
             'isVisibleOnProductPage'  => (bool)$this->config->getValue('visible_on_product'),
             'isGuestCheckoutAllowed'  => $isGuestCheckoutAllowed,
             'sdkUrl' => $this->sdkUrl->getUrl(),
             'dataAttributes' => [
-                'data-partner-attribution-id' => ($config) ? $config->getBuildNotationCode() : ''
+                'data-partner-attribution-id' => $this->paypalConfig->getBuildNotationCode()
             ]
         ];
     }

app/code/Magento/Paypal/Test/Unit/Model/SmartButtonConfigTest.php

@@ -16,7 +16,6 @@
 use Magento\Store\Model\StoreManagerInterface;
 use PHPUnit\Framework\MockObject\MockObject;
 use PHPUnit\Framework\TestCase;
-use Magento\Paypal\Model\Payflowpro;
 
 /**
  * Test for smart button config
@@ -38,11 +37,6 @@ class SmartButtonConfigTest extends TestCase
      */
     private $configMock;
 
-    /**
-     * @var MockObject
-     */
-    private $payflowproMock;
-
     /**
      * @inheritDoc
      */
@@ -52,7 +46,6 @@ protected function setUp(): void
         $this->configMock           = $this->getMockBuilder(Config::class)
             ->disableOriginalConstructor()
             ->getMock();
-        $this->payflowproMock       = $this->createMock(Payflowpro::class);
 
         /** @var ScopeConfigInterface|MockObject $scopeConfigMock */
         $scopeConfigMock = $this->getMockForAbstractClass(ScopeConfigInterface::class);
@@ -74,7 +67,7 @@ protected function setUp(): void
             $configFactoryMock,
             $scopeConfigMock,
             $sdkUrl,
-            $this->payflowproMock,
+            $this->configMock,
             $this->getDefaultStyles()
         );
     }