Skip to content

Commit 9e2c7d0

Browse files
committed
ACPT-698: Review public PR regarding import
1 parent 6f59233 commit 9e2c7d0

File tree

1 file changed

+17
-21
lines changed

1 file changed

+17
-21
lines changed

app/code/Magento/AdvancedPricingImportExport/Model/Import/AdvancedPricing.php

Lines changed: 17 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -21,22 +21,22 @@
2121
*/
2222
class AdvancedPricing extends \Magento\ImportExport\Model\Import\Entity\AbstractEntity
2323
{
24-
const VALUE_ALL_GROUPS = 'ALL GROUPS';
25-
const VALUE_ALL_WEBSITES = 'All Websites';
26-
const COL_SKU = 'sku';
27-
const COL_TIER_PRICE_WEBSITE = 'tier_price_website';
28-
const COL_TIER_PRICE_CUSTOMER_GROUP = 'tier_price_customer_group';
29-
const COL_TIER_PRICE_QTY = 'tier_price_qty';
30-
const COL_TIER_PRICE = 'tier_price';
31-
const COL_TIER_PRICE_PERCENTAGE_VALUE = 'percentage_value';
32-
const COL_TIER_PRICE_TYPE = 'tier_price_value_type';
33-
const TIER_PRICE_TYPE_FIXED = 'Fixed';
34-
const TIER_PRICE_TYPE_PERCENT = 'Discount';
35-
const TABLE_TIER_PRICE = 'catalog_product_entity_tier_price';
36-
const DEFAULT_ALL_GROUPS_GROUPED_PRICE_VALUE = '0';
37-
const ENTITY_TYPE_CODE = 'advanced_pricing';
38-
const VALIDATOR_MAIN = 'validator';
39-
const VALIDATOR_WEBSITE = 'validator_website';
24+
public const VALUE_ALL_GROUPS = 'ALL GROUPS';
25+
public const VALUE_ALL_WEBSITES = 'All Websites';
26+
public const COL_SKU = 'sku';
27+
public const COL_TIER_PRICE_WEBSITE = 'tier_price_website';
28+
public const COL_TIER_PRICE_CUSTOMER_GROUP = 'tier_price_customer_group';
29+
public const COL_TIER_PRICE_QTY = 'tier_price_qty';
30+
public const COL_TIER_PRICE = 'tier_price';
31+
public const COL_TIER_PRICE_PERCENTAGE_VALUE = 'percentage_value';
32+
public const COL_TIER_PRICE_TYPE = 'tier_price_value_type';
33+
public const TIER_PRICE_TYPE_FIXED = 'Fixed';
34+
public const TIER_PRICE_TYPE_PERCENT = 'Discount';
35+
public const TABLE_TIER_PRICE = 'catalog_product_entity_tier_price';
36+
public const DEFAULT_ALL_GROUPS_GROUPED_PRICE_VALUE = '0';
37+
public const ENTITY_TYPE_CODE = 'advanced_pricing';
38+
public const VALIDATOR_MAIN = 'validator';
39+
public const VALIDATOR_WEBSITE = 'validator_website';
4040

4141
/**
4242
* @deprecated
@@ -78,7 +78,7 @@ class AdvancedPricing extends \Magento\ImportExport\Model\Import\Entity\Abstract
7878
/**
7979
* Valid column names.
8080
*
81-
* @array
81+
* @var array
8282
*/
8383
protected $validColumnNames = [
8484
self::COL_SKU,
@@ -144,8 +144,6 @@ class AdvancedPricing extends \Magento\ImportExport\Model\Import\Entity\Abstract
144144
protected $_permanentAttributes = [self::COL_SKU];
145145

146146
/**
147-
* Catalog product entity
148-
*
149147
* @var string
150148
*/
151149
protected $_catalogProductEntity;
@@ -156,8 +154,6 @@ class AdvancedPricing extends \Magento\ImportExport\Model\Import\Entity\Abstract
156154
protected $dateTime;
157155

158156
/**
159-
* Product entity link field
160-
*
161157
* @var string
162158
*/
163159
private $productEntityLinkField;

0 commit comments

Comments
 (0)