MC-16106: [2.3] Failed UI upgrade

Author: fascinosum

app/code/Magento/Authorization/Model/Role.php

@@ -40,7 +40,7 @@ class Role extends \Magento\Framework\Model\AbstractModel
      * @param \Magento\Authorization\Model\ResourceModel\Role\Collection $resourceCollection
      * @param array $data
      */
-    public function __construct(
+    public function __construct( //phpcs:ignore Generic.CodeAnalysis.UselessOverridingMethod
         \Magento\Framework\Model\Context $context,
         \Magento\Framework\Registry $registry,
         \Magento\Authorization\Model\ResourceModel\Role $resource,

app/code/Magento/Backend/Model/Auth/Session.php

@@ -20,6 +20,7 @@
  * @method \Magento\Backend\Model\Auth\Session setUpdatedAt(int $value)
  *
  * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
+ * @SuppressWarnings(PHPMD.CookieAndSessionMisuse)
  * @todo implement solution that keeps is_first_visit flag in session during redirects
  * @api
  * @since 100.0.2

app/code/Magento/User/Model/User.php

@@ -448,7 +448,6 @@ public function roleUserExists()
      * @throws NotificationExceptionInterface
      * @deprecated
      * @see NotificatorInterface::sendForgotPassword()
-     *
      */
     public function sendPasswordResetConfirmationEmail()
     {

lib/internal/Magento/Framework/App/Response/Http.php

@@ -18,6 +18,8 @@
 
 /**
  * HTTP response
+ *
+ * @SuppressWarnings(PHPMD.CookieAndSessionMisuse)
  */
 class Http extends \Magento\Framework\HTTP\PhpEnvironment\Response
 {

lib/internal/Magento/Framework/Model/AbstractExtensibleModel.php

@@ -183,6 +183,10 @@ public function setCustomAttribute($attributeCode, $attributeValue)
 
     /**
      * {@inheritdoc} Added custom attributes support.
+     *
+     * @param string|array $key
+     * @param mixed $value
+     * @return $this
      */
     public function setData($key, $value = null)
     {
@@ -199,6 +203,9 @@ public function setData($key, $value = null)
 
     /**
      * {@inheritdoc} Unset customAttributesChanged flag
+     *
+     * @param null|string|array $key
+     * @return $thi
      */
     public function unsetData($key = null)
     {

lib/internal/Magento/Framework/Translate/Inline/Proxy.php

@@ -122,7 +122,7 @@ public function getParser()
     /**
      * Replace translation templates with HTML fragments
      *
-     * @param array|string &$body
+     * @param array|string $body
      * @param bool $isJson
      * @return $this
      */